components/proximity_auth/cryptauth/cryptauth_api_call_flow.h - Issue 738593002: Introduce CryptAuthClient, a class capable of performing all CryptAuth APIs.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/proximity_auth/cryptauth/cryptauth_api_call_flow.h

Issue 738593002: Introduce CryptAuthClient, a class capable of performing all CryptAuth APIs. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: fix typo Created 6 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/proximity_auth/cryptauth/cryptauth_access_token_fetcher.h ('k') | components/proximity_auth/cryptauth/cryptauth_api_call_flow.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/proximity_auth/cryptauth/cryptauth_api_call_flow.h

diff --git a/components/proximity_auth/cryptauth/cryptauth_api_call_flow.h b/components/proximity_auth/cryptauth/cryptauth_api_call_flow.h

index 3dd8f8cf6cade3c5a10582e0eb044300e6a4e7d1..7625a235769c3d3818fcc22f5c707182899a192e 100644

--- a/components/proximity_auth/cryptauth/cryptauth_api_call_flow.h

+++ b/components/proximity_auth/cryptauth/cryptauth_api_call_flow.h

@@ -32,11 +32,11 @@ class CryptAuthApiCallFlow : public OAuth2ApiCallFlow {

// result_callback: Called when the flow completes successfully with a

// serialized response proto.

// error_callback: Called when the flow completes with an error.

- void Start(net::URLRequestContextGetter* context,

- const std::string& access_token,

- const std::string& serialized_request,

- ResultCallback result_callback,

- ErrorCallback error_callback);

+ virtual void Start(net::URLRequestContextGetter* context,

+ const std::string& access_token,

+ const std::string& serialized_request,

+ const ResultCallback& result_callback,

+ const ErrorCallback& error_callback);

protected:

// Reduce the visibility of OAuth2ApiCallFlow::Start() to avoid exposing