Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(592)

Issue 738543002: PDF: Correct typo in form fill environment functions (Closed)

Created:
6 years, 1 month ago by Lei Zhang
Modified:
6 years, 1 month ago
Reviewers:
Bo Xu, jam
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

PDF: Correct typo in form fill environment functions Rolls PDF to 1dc4f4112d72c63e465d6f09695ebea1119d39a6. This brings in: 1dc4f411: Rename functions in test code also 2c021e02: Correct typo in form fill environment functions 893fe94f: Remove FX_LPCWSTR cast to wchar_t* literals d66fda28: Change from 'this' to L'this' and remove the cast Original CL: https://codereview.chromium.org/711553003/ Original Author: bo_xu@foxitsoftware.com Committed: https://crrev.com/1de47c7dc023e612aa55d4576e1092d40fd04801 Cr-Commit-Position: refs/heads/master@{#304530}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M DEPS View 1 chunk +1 line, -1 line 0 comments Download
M pdf/pdfium/pdfium_engine.cc View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
Lei Zhang
6 years, 1 month ago (2014-11-17 22:24:09 UTC) #2
Bo Xu
On 2014/11/17 22:24:09, Lei Zhang wrote: LGTM
6 years, 1 month ago (2014-11-17 22:27:27 UTC) #3
jam
lgtm
6 years, 1 month ago (2014-11-17 22:32:43 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/738543002/1
6 years, 1 month ago (2014-11-17 22:35:50 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years, 1 month ago (2014-11-18 01:02:47 UTC) #8
commit-bot: I haz the power
6 years, 1 month ago (2014-11-18 01:03:33 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/1de47c7dc023e612aa55d4576e1092d40fd04801
Cr-Commit-Position: refs/heads/master@{#304530}

Powered by Google App Engine
This is Rietveld 408576698