Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(535)

Issue 738483002: Revert of [Telemetry] Add browser option that allows disabling crash service (Closed)

Created:
6 years, 1 month ago by nednguyen
Modified:
6 years, 1 month ago
CC:
chromium-reviews, telemetry+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Revert of [Telemetry] Add browser option that allows disabling crash service (patchset #1 id:1 of https://codereview.chromium.org/702173002/) Reason for revert: Bug 424024 is marked fixed. Crash service was not the reason of the flakiness. Note: first revert attempt was reverted (https://codereview.chromium.org/721443006/) Original issue's description: > [Telemetry] Add browser option that allows disabling crash service > > TBR=dtu@chromium.org > > BUG=430246 > > Committed: https://crrev.com/797b1a69e4a74be52c6a3841547072321b297a7f > Cr-Commit-Position: refs/heads/master@{#302903} TBR=chrishenry@google.com,kbr@chromium.org,tonyg@chromium.org,dtu@chromium.org BUG=430246 Committed: https://crrev.com/65a306a6648cafe5a43f4ca3d2f8bc206fb3a92c Cr-Commit-Position: refs/heads/master@{#304476}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -11 lines) Patch
M tools/telemetry/telemetry/core/backends/chrome/desktop_browser_backend.py View 1 chunk +1 line, -3 lines 0 comments Download
M tools/telemetry/telemetry/core/browser_options.py View 2 chunks +0 lines, -8 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
nednguyen
Created Revert of [Telemetry] Add browser option that allows disabling crash service
6 years, 1 month ago (2014-11-17 20:02:06 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/738483002/1
6 years, 1 month ago (2014-11-17 20:02:51 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years, 1 month ago (2014-11-17 21:02:13 UTC) #4
commit-bot: I haz the power
6 years, 1 month ago (2014-11-17 21:03:24 UTC) #5
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/65a306a6648cafe5a43f4ca3d2f8bc206fb3a92c
Cr-Commit-Position: refs/heads/master@{#304476}

Powered by Google App Engine
This is Rietveld 408576698