Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(55)

Issue 738463003: Don't set page scale limits inside EventSender::setPageScaleFactor. (Closed)

Created:
6 years, 1 month ago by bokan
Modified:
6 years, 1 month ago
Reviewers:
Dirk Pranke
CC:
chromium-reviews, darin-cc_chromium.org, mkwst+moarreviews-shell_chromium.org, jam, jochen+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Don't set page scale limits inside EventSender::setPageScaleFactor. This prevents proper testing of pinch-zoom as the limits change on every zoom and limits are used to calculate the main frame size in virtual-viewport pinch to zoom. This is part of a 3-sided patch: 1) Add a setPageScaleFactorLimits to EventSender 2) Change existing layout tests that use setPageScaleFactor to use this method to set up the limits. 3) This patch removes the setPageScaleLimits call inside setPageScaleFactor. BUG=435151 Committed: https://crrev.com/323f0ecd1c35e0e0588afcdc1178709af99e3b60 Cr-Commit-Position: refs/heads/master@{#305084}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -1 line) Patch
M content/shell/renderer/test_runner/event_sender.cc View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
bokan
6 years, 1 month ago (2014-11-19 16:39:10 UTC) #2
Dirk Pranke
lgtm
6 years, 1 month ago (2014-11-19 22:28:28 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/738463003/1
6 years, 1 month ago (2014-11-20 21:14:42 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years, 1 month ago (2014-11-20 22:04:04 UTC) #6
commit-bot: I haz the power
6 years, 1 month ago (2014-11-20 22:04:55 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/323f0ecd1c35e0e0588afcdc1178709af99e3b60
Cr-Commit-Position: refs/heads/master@{#305084}

Powered by Google App Engine
This is Rietveld 408576698