Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(180)

Unified Diff: dart/pkg/dart2js_incremental/lib/library_updater.dart

Issue 738423002: Use serialized scope info to test incremental compiler. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge
Patch Set: Merged with r41954. Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « dart/pkg/dart2js_incremental/lib/dart2js_incremental.dart ('k') | dart/site/try/poi/poi.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: dart/pkg/dart2js_incremental/lib/library_updater.dart
diff --git a/dart/pkg/dart2js_incremental/lib/library_updater.dart b/dart/pkg/dart2js_incremental/lib/library_updater.dart
index 6ec3330589877a4a850b56c7d3ff76f106cf08b3..17cebea158ed64a204d2d6f988315897e8fe9aab 100644
--- a/dart/pkg/dart2js_incremental/lib/library_updater.dart
+++ b/dart/pkg/dart2js_incremental/lib/library_updater.dart
@@ -545,7 +545,7 @@ class LibraryUpdater extends JsFeatures {
if (!element.isClass) {
compiler.enqueuer.resolution.addToWorkList(element);
} else {
- element.ensureResolved(compiler);
+ NO_WARN(element).ensureResolved(compiler);
}
}
compiler.processQueue(compiler.enqueuer.resolution, null);
@@ -756,7 +756,7 @@ abstract class ReuseFunction {
}
}
-class RemovalUpdate extends Update {
+abstract class RemovalUpdate extends Update {
ElementX get element;
RemovalUpdate(Compiler compiler)
@@ -919,7 +919,7 @@ class RemovedClassUpdate extends RemovalUpdate with JsFeatures {
class RemovedFieldUpdate extends RemovalUpdate with JsFeatures {
final FieldElementX element;
- bool wasStateCaptured;
+ bool wasStateCaptured = false;
jsAst.Node elementAccess;
@@ -930,6 +930,10 @@ class RemovedFieldUpdate extends RemovalUpdate with JsFeatures {
RemovedFieldUpdate(Compiler compiler, this.element)
: super(compiler);
+ PartialFieldList get before => element.declarationSite;
+
+ PartialFieldList get after => null;
+
void captureState() {
if (wasStateCaptured) throw "captureState was called twice.";
wasStateCaptured = true;
@@ -985,7 +989,7 @@ class AddedFunctionUpdate extends Update with JsFeatures {
enclosing = enclosing.compilationUnit;
}
PartialFunctionElement copy = element.copyWithEnclosing(enclosing);
- container.addMember(copy, compiler);
+ NO_WARN(container).addMember(copy, compiler);
return copy;
}
}
@@ -1025,7 +1029,7 @@ class AddedFieldUpdate extends Update with JsFeatures {
FieldElementX apply() {
FieldElementX copy = element.copyWithEnclosing(container);
- container.addMember(copy, compiler);
+ NO_WARN(container).addMember(copy, compiler);
return copy;
}
}
@@ -1165,3 +1169,6 @@ class EmitterHelper extends JsFeatures {
return builder.fields;
}
}
+
+// TODO(ahe): Remove this method.
+NO_WARN(x) => x;
« no previous file with comments | « dart/pkg/dart2js_incremental/lib/dart2js_incremental.dart ('k') | dart/site/try/poi/poi.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698