Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(21)

Issue 738413002: [Android] Extract MD5sum logic. (Closed)

Created:
6 years, 1 month ago by jbudorick
Modified:
6 years, 1 month ago
Reviewers:
klundberg, perezju
CC:
chromium-reviews, klundberg+watch_chromium.org, yfriedman+watch_chromium.org, jbudorick+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

[Android] Extract MD5sum logic. BUG=428729, 433101 Committed: https://crrev.com/08a5b328c0adcdf952eb77564aae6693645f836f Cr-Commit-Position: refs/heads/master@{#305100}

Patch Set 1 #

Total comments: 24

Patch Set 2 : #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+268 lines, -19 lines) Patch
M build/android/PRESUBMIT.py View 1 1 chunk +1 line, -0 lines 0 comments Download
M build/android/pylib/constants.py View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M build/android/pylib/device/device_utils.py View 1 2 2 chunks +8 lines, -6 lines 0 comments Download
M build/android/pylib/instrumentation/test_jar.py View 4 chunks +3 lines, -12 lines 0 comments Download
A build/android/pylib/utils/md5sum.py View 1 2 1 chunk +72 lines, -0 lines 0 comments Download
A build/android/pylib/utils/md5sum_test.py View 1 1 chunk +183 lines, -0 lines 0 comments Download
M build/android/pylib/utils/mock_calls.py View 1 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 22 (6 generated)
jbudorick
Note that this is slightly slower than the existing implementation, presumably because of the shell ...
6 years, 1 month ago (2014-11-20 15:27:50 UTC) #2
klundberg
What is slightly slower? How much of a slowdown do you think we will see ...
6 years, 1 month ago (2014-11-20 15:37:41 UTC) #3
jbudorick
On 2014/11/20 15:37:41, klundberg wrote: > What is slightly slower? How much of a slowdown ...
6 years, 1 month ago (2014-11-20 15:47:36 UTC) #4
klundberg
On 2014/11/20 15:47:36, jbudorick wrote: > On 2014/11/20 15:37:41, klundberg wrote: > > What is ...
6 years, 1 month ago (2014-11-20 15:55:01 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/738413002/1
6 years, 1 month ago (2014-11-20 16:54:53 UTC) #7
perezju
https://codereview.chromium.org/738413002/diff/1/build/android/pylib/utils/md5sum.py File build/android/pylib/utils/md5sum.py (right): https://codereview.chromium.org/738413002/diff/1/build/android/pylib/utils/md5sum.py#newcode21 build/android/pylib/utils/md5sum.py:21: 'test -f {path} -o -d {path} ' why not ...
6 years, 1 month ago (2014-11-20 17:04:53 UTC) #8
perezju
https://codereview.chromium.org/738413002/diff/1/build/android/pylib/utils/md5sum.py File build/android/pylib/utils/md5sum.py (right): https://codereview.chromium.org/738413002/diff/1/build/android/pylib/utils/md5sum.py#newcode69 build/android/pylib/utils/md5sum.py:69: out = device.RunShellCommand(['sh', md5sum_device_script_file.name]) On 2014/11/20 17:04:53, perezju wrote: ...
6 years, 1 month ago (2014-11-20 17:16:13 UTC) #10
jbudorick
Addressed comments + added tests. https://codereview.chromium.org/738413002/diff/1/build/android/pylib/utils/md5sum.py File build/android/pylib/utils/md5sum.py (right): https://codereview.chromium.org/738413002/diff/1/build/android/pylib/utils/md5sum.py#newcode21 build/android/pylib/utils/md5sum.py:21: 'test -f {path} -o ...
6 years, 1 month ago (2014-11-20 19:38:08 UTC) #11
perezju
https://codereview.chromium.org/738413002/diff/1/build/android/pylib/utils/md5sum.py File build/android/pylib/utils/md5sum.py (right): https://codereview.chromium.org/738413002/diff/1/build/android/pylib/utils/md5sum.py#newcode21 build/android/pylib/utils/md5sum.py:21: 'test -f {path} -o -d {path} ' On 2014/11/20 ...
6 years, 1 month ago (2014-11-20 20:38:42 UTC) #12
jbudorick
https://codereview.chromium.org/738413002/diff/1/build/android/pylib/utils/md5sum.py File build/android/pylib/utils/md5sum.py (right): https://codereview.chromium.org/738413002/diff/1/build/android/pylib/utils/md5sum.py#newcode34 build/android/pylib/utils/md5sum.py:34: paths = [paths] On 2014/11/20 20:38:42, perezju wrote: > ...
6 years, 1 month ago (2014-11-20 20:58:13 UTC) #13
perezju
lgtm!
6 years, 1 month ago (2014-11-20 21:52:35 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/738413002/40001
6 years, 1 month ago (2014-11-20 21:54:37 UTC) #16
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/25643)
6 years, 1 month ago (2014-11-20 22:02:06 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/738413002/40001
6 years, 1 month ago (2014-11-20 22:52:42 UTC) #20
commit-bot: I haz the power
Committed patchset #3 (id:40001)
6 years, 1 month ago (2014-11-20 22:58:15 UTC) #21
commit-bot: I haz the power
6 years, 1 month ago (2014-11-20 22:59:51 UTC) #22
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/08a5b328c0adcdf952eb77564aae6693645f836f
Cr-Commit-Position: refs/heads/master@{#305100}

Powered by Google App Engine
This is Rietveld 408576698