Issue 738373002: [DevTools] Used generated inspector protocol handler

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 738373002: [DevTools] Used generated inspector protocol handler (Closed)

Created:
6 years, 1 month ago by vkuzkokov

Modified:
6 years, 1 month ago

Reviewers:
dgozman

CC:
chromium-reviews, vsevik, jam, yurys, paulirish+reviews_chromium.org, darin-cc_chromium.org, devtools-reviews_chromium.org, aandrey+blink_chromium.org, pfeldman

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Project:
chromium

Visibility:
Public.

More Reviews

Description

[DevTools] Used generated inspector protocol handler BUG=405566 Committed: https://crrev.com/2aaf4e3d374dd56b56bbb1177bf114f502a6f6bf Cr-Commit-Position: refs/heads/master@{#305010}

Patch Set 1 #

Created: 6 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+12 lines, -5 lines)			Patch
M	content/browser/devtools/protocol/inspector_handler.h	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	content/browser/devtools/protocol/inspector_handler.cc	View	1 chunk	+4 lines, -0 lines	0 comments	Download
M	content/browser/devtools/render_view_devtools_agent_host.h	View	2 chunks	+2 lines, -0 lines	0 comments	Download
M	content/browser/devtools/render_view_devtools_agent_host.cc	View	4 chunks	+4 lines, -5 lines	0 comments	Download

Messages

Total messages: 7 (2 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/738373002/1

6 years, 1 month ago (2014-11-20 13:07:11 UTC) #5

commit-bot: I haz the power

6 years, 1 month ago (2014-11-20 14:20:37 UTC) #7

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/2aaf4e3d374dd56b56bbb1177bf114f502a6f6bf
Cr-Commit-Position: refs/heads/master@{#305010}

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages