Enable subpixel positioning for UI

ui/gfx/win/direct_write.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "ui/gfx/win/direct_write.h"
 
+#include <dwrite.h>
+
 #include "base/basictypes.h"
 #include "base/command_line.h"
 #include "base/metrics/field_trial.h"
 #include "base/win/registry.h"
+#include "base/win/scoped_comptr.h"
 #include "base/win/windows_version.h"
+#include "skia/ext/fontmgr_default_win.h"
+#include "third_party/skia/include/ports/SkTypeface_win.h"
+#include "ui/gfx/platform_font_win.h"
 #include "ui/gfx/switches.h"
 #include "ui/gfx/win/dpi.h"
 
 namespace gfx {
 namespace win {
 
 bool ShouldUseDirectWrite() {
   // If the flag is currently on, and we're on Win7 or above, we enable
   // DirectWrite. Skia does not require the additions to DirectWrite in QFE
   // 2670838, but a simple 'better than XP' check is not enough.
@@ skipping 30 matching lines @@
   const DWORD kMaxAllowedFontsBeforeFallbackToGDI = 1750;
   if (reg_iterator.ValueCount() >= kMaxAllowedFontsBeforeFallbackToGDI)
     return false;
 
   // Otherwise, check the field trial.
   const std::string group_name =
       base::FieldTrialList::FindFullName("DirectWrite");
   return group_name != "Disabled";
 }
 
+void MaybeInitializeDirectWrite() {

[sky, 2014/12/01 15:57:22]

What happens if this is invoked multiple times?

[ckocagil, 2014/12/01 19:31:53]

We likely leak some objects (DWrite or SkFontMgr) with each call. Changed this
function to skip subsequent calls. Should I add a NOTREACHED too?

+  if (!ShouldUseDirectWrite() ||
+      CommandLine::ForCurrentProcess()->HasSwitch(
+          switches::kDisableDirectWriteForUI) ||
+      CommandLine::ForCurrentProcess()->HasSwitch(
+          switches::kDisableHarfBuzzRenderText)) {
+    return;
+  }
+
+  typedef decltype(DWriteCreateFactory)* DWriteCreateFactoryProc;

[sky, 2014/12/01 15:57:22]

Use using for improved clarity.

[ckocagil, 2014/12/01 19:31:52]

Done.

+  HMODULE dwrite_dll = LoadLibraryW(L"dwrite.dll");
+  if (!dwrite_dll)
+    return;
+
+  DWriteCreateFactoryProc dwrite_create_factory_proc =
+      reinterpret_cast<DWriteCreateFactoryProc>(
+          GetProcAddress(dwrite_dll, "DWriteCreateFactory"));
+  // Not finding the DWriteCreateFactory function indicates a corrupt dll.
+  CHECK(dwrite_create_factory_proc);
+
+  base::win::ScopedComPtr<IDWriteFactory> factory;
+
+  CHECK(SUCCEEDED(
+      dwrite_create_factory_proc(
+          DWRITE_FACTORY_TYPE_SHARED,
+        __uuidof(IDWriteFactory),
+        reinterpret_cast<IUnknown**>(factory.Receive()))));
+  // The skia call to create a new DirectWrite font manager instance can fail
+  // if we are unable to get the system font collection from the DirectWrite
+  // factory. The GetSystemFontCollection method in the IDWriteFactory
+  // interface fails with E_INVALIDARG on certain Windows 7 gold versions
+  // (6.1.7600.*). We should just use GDI in these cases.
+  SkFontMgr* direct_write_font_mgr = SkFontMgr_New_DirectWrite(factory.get());
+  if (direct_write_font_mgr) {
+    SetDefaultSkiaFactory(direct_write_font_mgr);
+    gfx::PlatformFontWin::SetDirectWriteFactory(factory.get());
+  }
+}
+
 }  // namespace win
 }  // namespace gfx