build/config/BUILDCONFIG.gn - Issue 738333002: Make goma work on win GN builds.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: build/config/BUILDCONFIG.gn

Issue 738333002: Make goma work on win GN builds. (Closed) Base URL: http://chromium.googlesource.com/chromium/src.git@master

Patch Set: update w/ more review feedback; get vc_bin_dir from setup_toolchain.py Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: build/config/BUILDCONFIG.gn

diff --git a/build/config/BUILDCONFIG.gn b/build/config/BUILDCONFIG.gn

index 0d65c44da6405e085e737fc6ad50a1f47a13fdbb..6718767e9d5a37e319ddeb8a7e3e28c143b388a0 100644

--- a/build/config/BUILDCONFIG.gn

+++ b/build/config/BUILDCONFIG.gn

@@ -373,8 +373,14 @@ if (symbol_level == -1) {

}

# Symbol setup.

+import("//build/toolchain/goma.gni")

Dirk Pranke 2014/11/21 22:16:42 We still have the concerns about global goma vars

if (symbol_level == 2) {

- _default_symbols_config = "//build/config/compiler:symbols"

+ if (is_win && use_goma) {

+ # GOMA doesn't support full symbols on Win.

scottmg 2014/11/21 22:26:59 please change this comment still

+ _default_symbols_config = "//build/config/compiler:minimal_symbols"

+ } else {

+ _default_symbols_config = "//build/config/compiler:symbols"

+ }

} else if (symbol_level == 1) {

_default_symbols_config = "//build/config/compiler:minimal_symbols"

} else if (symbol_level == 0) {

« no previous file with comments | « no previous file | build/toolchain/win/BUILD.gn » ('j') | build/toolchain/win/setup_toolchain.py » ('J')