Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(625)

Side by Side Diff: build/config/compiler/BUILD.gn

Issue 738333002: Make goma work on win GN builds. (Closed) Base URL: http://chromium.googlesource.com/chromium/src.git@master
Patch Set: move goma symbol logic out of buildconfig Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | build/toolchain/win/BUILD.gn » ('j') | build/toolchain/win/BUILD.gn » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright (c) 2013 The Chromium Authors. All rights reserved. 1 # Copyright (c) 2013 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 import("//build/config/android/config.gni") 5 import("//build/config/android/config.gni")
6 if (cpu_arch == "arm") { 6 if (cpu_arch == "arm") {
7 import("//build/config/arm.gni") 7 import("//build/config/arm.gni")
8 } 8 }
9 if (is_posix) { 9 if (is_posix) {
10 import("//build/config/gcc/gcc_version.gni") 10 import("//build/config/gcc/gcc_version.gni")
(...skipping 933 matching lines...) Expand 10 before | Expand all | Expand 10 after
944 cflags += [ 944 cflags += [
945 "-O2", 945 "-O2",
946 ] 946 ]
947 } 947 }
948 } 948 }
949 949
950 # Symbols ---------------------------------------------------------------------- 950 # Symbols ----------------------------------------------------------------------
951 951
952 config("symbols") { 952 config("symbols") {
953 if (is_win) { 953 if (is_win) {
954 cflags = [ "/Zi" ] # Produce PDB file, no edit and continue. 954 import("//build/toolchain/goma.gni")
955 if (use_goma) {
956 cflags = [ "/Z7" ] # No PDB file
957 } else {
958 cflags = [ "/Zi" ] # Produce PDB file, no edit and continue.
959 }
955 ldflags = [ "/DEBUG" ] 960 ldflags = [ "/DEBUG" ]
956 } else { 961 } else {
957 cflags = [ "-g2" ] 962 cflags = [ "-g2" ]
958 if (use_debug_fission) { 963 if (use_debug_fission) {
959 cflags += [ "-gsplit-dwarf" ] 964 cflags += [ "-gsplit-dwarf" ]
960 } 965 }
961 } 966 }
962 } 967 }
963 968
964 config("minimal_symbols") { 969 config("minimal_symbols") {
965 if (is_win) { 970 if (is_win) {
966 # Linker symbols for backtraces only. 971 # Linker symbols for backtraces only.
967 ldflags = [ "/DEBUG" ] 972 ldflags = [ "/DEBUG" ]
968 } else { 973 } else {
969 cflags = [ "-g1" ] 974 cflags = [ "-g1" ]
970 if (use_debug_fission) { 975 if (use_debug_fission) {
971 cflags += [ "-gsplit-dwarf" ] 976 cflags += [ "-gsplit-dwarf" ]
972 } 977 }
973 } 978 }
974 } 979 }
975 980
976 config("no_symbols") { 981 config("no_symbols") {
977 if (!is_win) { 982 if (!is_win) {
978 cflags = [ "-g0" ] 983 cflags = [ "-g0" ]
979 } 984 }
980 } 985 }
OLDNEW
« no previous file with comments | « no previous file | build/toolchain/win/BUILD.gn » ('j') | build/toolchain/win/BUILD.gn » ('J')

Powered by Google App Engine
This is Rietveld 408576698