Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(119)

Issue 738323002: OOP PDF: Forward keyboard events to a constrained web dialog's initiator's delegate. (Closed)

Created:
6 years, 1 month ago by Sam McNally
Modified:
6 years, 1 month ago
Reviewers:
sky
CC:
chromium-reviews, tfarina, raymes, chrome-apps-syd-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

OOP PDF: Forward keyboard events to a constrained web dialog's initiator's delegate. WebDialogWebContentsDelegateViews forwards keyboard events that it receives to the Browser for its initiating WebContents. The out-of-process PDF plugin is implemented as a nested WebContents containing the extension implementation within the WebContents of the tab. When a print-preview dialog is launched for a PDF from the out-of-process plugin, the dialog's initiator is the nested WebContents, which does not have an associated Browser. This causes keyboard events to be dropped, breaking keyboard shortcuts. This CL fixes this by changing WebDialogWebContentsDelegateViews to forward keyboard events to its initiator's delegate. BUG=423453 TEST=Run with --out-of-process-pdf. Open a PDF and use the print toolbar button to launch the print preview dialog. From this dialog, keyboard shortcuts should work, e.g. escape should cancel the dialog. Committed: https://crrev.com/7ed352b8552d5549410d53b0eef14b68aa41bf1a Cr-Commit-Position: refs/heads/master@{#305125}

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -4 lines) Patch
M chrome/browser/ui/views/constrained_web_dialog_delegate_views.cc View 1 chunk +5 lines, -4 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
Sam McNally
6 years, 1 month ago (2014-11-20 03:52:00 UTC) #3
sky
LGTM
6 years, 1 month ago (2014-11-20 15:06:08 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/738323002/20001
6 years, 1 month ago (2014-11-20 23:02:12 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:20001)
6 years, 1 month ago (2014-11-21 00:43:49 UTC) #7
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/7ed352b8552d5549410d53b0eef14b68aa41bf1a Cr-Commit-Position: refs/heads/master@{#305125}
6 years, 1 month ago (2014-11-21 00:44:21 UTC) #8
dgarrett
6 years, 1 month ago (2014-11-21 01:09:18 UTC) #9
Message was sent while issue was closed.
On 2014/11/21 00:44:21, I haz the power (commit-bot) wrote:
> Patchset 1 (id:??) landed as
> https://crrev.com/7ed352b8552d5549410d53b0eef14b68aa41bf1a
> Cr-Commit-Position: refs/heads/master@{#305125}

Just btw, I think you had the wrong bug number in the description.

Powered by Google App Engine
This is Rietveld 408576698