Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(360)

Issue 738313003: Fix WeakPtrFactory member ordering in components (Closed)

Created:
6 years, 1 month ago by MRV
Modified:
6 years, 1 month ago
Reviewers:
blundell
CC:
chromium-reviews, dmichael (off chromium)
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Fix WeakPtrFactory member ordering in components Changing in the intialization order of WeakPtrFactory such that all member variables should appear before the WeakPtrFactory to ensure that any WeakPtrs to Controller are invalidated before its members variable's destructors are executed, rendering them invalid. BUG=303818 Committed: https://crrev.com/574b801fe54f36919a49c9f5c90b11ce20e880f0 Cr-Commit-Position: refs/heads/master@{#305227}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -3 lines) Patch
M components/data_reduction_proxy/core/browser/data_reduction_proxy_statistics_prefs.h View 1 chunk +2 lines, -1 line 0 comments Download
M components/data_reduction_proxy/core/browser/data_reduction_proxy_statistics_prefs.cc View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
MRV
On 2014/11/20 14:30:13, MRV wrote: > mailto:mohan.reddy@samsung.com changed reviewers: > + mailto:blundell@chromium.org PTAL
6 years, 1 month ago (2014-11-20 14:31:07 UTC) #2
blundell
lgtm
6 years, 1 month ago (2014-11-21 15:32:46 UTC) #3
MRV
On 2014/11/21 15:32:46, blundell wrote: > lgtm Thanks mr. blundell for LGTM
6 years, 1 month ago (2014-11-21 15:33:45 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/738313003/1
6 years, 1 month ago (2014-11-21 15:33:56 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years, 1 month ago (2014-11-21 16:44:56 UTC) #7
commit-bot: I haz the power
6 years, 1 month ago (2014-11-21 16:45:43 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/574b801fe54f36919a49c9f5c90b11ce20e880f0
Cr-Commit-Position: refs/heads/master@{#305227}

Powered by Google App Engine
This is Rietveld 408576698