ChildProcessLauncher: Don't access context_ private members directly.

ChildProcessLauncher: Don't access context_ private members directly.

This cleanup should not modify behavior.

BUG=417532
R=creis@chromium.org

Committed: https://crrev.com/f7cbdde4cce0a5481968ff42d006dc040fbaf7e9
Cr-Commit-Position: refs/heads/master@{#305110}

[Charlie Reis, 2014-11-20 18:00:10]

LGTM with nits.

https://codereview.chromium.org/738283002/diff/1/content/browser/child_proces...
File content/browser/child_process_launcher.cc (right):

https://codereview.chromium.org/738283002/diff/1/content/browser/child_proces...
content/browser/child_process_launcher.cc:81: bool IsStarting() const { return
starting_; }
nit: is_starting()

https://codereview.chromium.org/738283002/diff/1/content/browser/child_proces...
content/browser/child_process_launcher.cc:83: const base::Process& GetProcess()
const { return process_; }
nit: process()

https://codereview.chromium.org/738283002/diff/1/content/browser/child_proces...
content/browser/child_process_launcher.cc:97: void Close() { process_.Close(); }
Minor nit: Perhaps this should not be defined inline, since Process::Closed()
isn't?

[rvargas (doing something else), 2014-11-20 22:36:14]

Thanks

https://codereview.chromium.org/738283002/diff/1/content/browser/child_proces...
File content/browser/child_process_launcher.cc (right):

https://codereview.chromium.org/738283002/diff/1/content/browser/child_proces...
content/browser/child_process_launcher.cc:81: bool IsStarting() const { return
starting_; }
On 2014/11/20 18:00:09, Charlie Reis wrote:
> nit: is_starting()

Done.

https://codereview.chromium.org/738283002/diff/1/content/browser/child_proces...
content/browser/child_process_launcher.cc:83: const base::Process& GetProcess()
const { return process_; }
On 2014/11/20 18:00:09, Charlie Reis wrote:
> nit: process()

Done.

https://codereview.chromium.org/738283002/diff/1/content/browser/child_proces...
content/browser/child_process_launcher.cc:97: void Close() { process_.Close(); }
On 2014/11/20 18:00:09, Charlie Reis wrote:
> Minor nit: Perhaps this should not be defined inline, since Process::Closed()
> isn't?

It is not defined inline to signal it is fast or that should be optimized; it's 
just because it is a one line method.

[rvargas (doing something else), 2014-11-20 22:36:22]

The CQ bit was checked by rvargas@chromium.org

[commit-bot: I haz the power, 2014-11-20 22:38:35]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/738283002/20001

[commit-bot: I haz the power, 2014-11-20 23:30:40]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2014-11-20 23:31:23]

Patchset 2 (id:??) landed as
https://crrev.com/f7cbdde4cce0a5481968ff42d006dc040fbaf7e9
Cr-Commit-Position: refs/heads/master@{#305110}