Notify primary display reassignment

Notify primary display reassignment

BUG=416286
TEST=covered by unittets, plus tested on device. (see bug for repro step)

Committed: https://crrev.com/04e27dd16f6075ba43be77a6e646b637e9538ccb
Cr-Commit-Position: refs/heads/master@{#304985}

[oshima, 2014-11-20 00:43:16]

Patchset #1 (id:1) has been deleted

[oshima, 2014-11-20 00:43:20]

Patchset #1 (id:20001) has been deleted

[oshima, 2014-11-20 00:45:33]

oshima@chromium.org changed reviewers:
+ mukai@chromium.org

[oshima, 2014-11-20 00:45:59]

Patchset #1 (id:40001) has been deleted

[Jun Mukai, 2014-11-20 00:58:38]

https://codereview.chromium.org/738243002/diff/60001/ash/display/display_cont...
File ash/display/display_controller_unittest.cc (right):

https://codereview.chromium.org/738243002/diff/60001/ash/display/display_cont...
ash/display/display_controller_unittest.cc:587: EXPECT_EQ(1,
observer.GetWorkareaChangedCountAndReset());
better to modify observer to recognize the primary change and add an expectation
that primary change arrives?

https://codereview.chromium.org/738243002/diff/60001/ash/display/display_mana...
File ash/display/display_manager_unittest.cc (right):

https://codereview.chromium.org/738243002/diff/60001/ash/display/display_mana...
ash/display/display_manager_unittest.cc:1388:
ash::Shell::GetInstance()->display_controller()->SwapPrimaryDisplay();
Doesn't "SwapPrimaryDisplay" need to emit DISPLAY_METRICS_PRIMARY?

[oshima, 2014-11-20 01:12:21]

https://codereview.chromium.org/738243002/diff/60001/ash/display/display_cont...
File ash/display/display_controller_unittest.cc (right):

https://codereview.chromium.org/738243002/diff/60001/ash/display/display_cont...
ash/display/display_controller_unittest.cc:587: EXPECT_EQ(1,
observer.GetWorkareaChangedCountAndReset());
On 2014/11/20 00:58:38, Jun Mukai wrote:
> better to modify observer to recognize the primary change and add an
expectation
> that primary change arrives?

Done.

https://codereview.chromium.org/738243002/diff/60001/ash/display/display_mana...
File ash/display/display_manager_unittest.cc (right):

https://codereview.chromium.org/738243002/diff/60001/ash/display/display_mana...
ash/display/display_manager_unittest.cc:1388:
ash::Shell::GetInstance()->display_controller()->SwapPrimaryDisplay();
On 2014/11/20 00:58:38, Jun Mukai wrote:
> Doesn't "SwapPrimaryDisplay" need to emit DISPLAY_METRICS_PRIMARY?

metrics is reset below.

[Jun Mukai, 2014-11-20 01:34:19]

https://codereview.chromium.org/738243002/diff/80001/ash/display/display_cont...
File ash/display/display_controller_unittest.cc (right):

https://codereview.chromium.org/738243002/diff/80001/ash/display/display_cont...
ash/display/display_controller_unittest.cc:106: ++workarea_changed_count_;
increment primary_changed_count_?

[oshima, 2014-11-20 01:45:48]

https://codereview.chromium.org/738243002/diff/80001/ash/display/display_cont...
File ash/display/display_controller_unittest.cc (right):

https://codereview.chromium.org/738243002/diff/80001/ash/display/display_cont...
ash/display/display_controller_unittest.cc:106: ++workarea_changed_count_;
On 2014/11/20 01:34:19, Jun Mukai wrote:
> increment primary_changed_count_?

oops, fixed. looks like I run the test on wrong console because it didn't
compile :(.

[Jun Mukai, 2014-11-20 01:55:10]

lgtm

[oshima, 2014-11-20 05:51:43]

The CQ bit was checked by oshima@chromium.org

[commit-bot: I haz the power, 2014-11-20 05:52:46]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/738243002/120001

[commit-bot: I haz the power, 2014-11-20 06:56:50]

Committed patchset #4 (id:120001)

[commit-bot: I haz the power, 2014-11-20 06:57:29]

Patchset 4 (id:??) landed as
https://crrev.com/04e27dd16f6075ba43be77a6e646b637e9538ccb
Cr-Commit-Position: refs/heads/master@{#304985}