[Extensions Toolbar Mac] Fix chevron position after animation

[Extensions Toolbar Mac] Fix chevron position after animation

If the chevron was animating in or out and then needs to move, the animation
should stop before the chevron's frame is set.

BUG=429810
Committed: https://crrev.com/f3dc55e3947548641b3a69dca33b1232b508b0b9
Cr-Commit-Position: refs/heads/master@{#305091}

[Devlin, 2014-11-19 23:51:37]

rdevlin.cronin@chromium.org changed reviewers:
+ avi@chromium.org

[Avi (use Gerrit), 2014-11-20 00:46:48]

lgtm

If you so choose.

https://codereview.chromium.org/738213002/diff/1/chrome/browser/ui/cocoa/exte...
File chrome/browser/ui/cocoa/extensions/browser_actions_controller.mm (right):

https://codereview.chromium.org/738213002/diff/1/chrome/browser/ui/cocoa/exte...
chrome/browser/ui/cocoa/extensions/browser_actions_controller.mm:737: nil];
NSDictionary* animationDictionary = @{
  NSViewAnimationTargetKey : chevronMenuButton_.get(),
  NSViewAnimationEffectKey : animationEffect
};

[Devlin, 2014-11-20 21:13:02]

https://codereview.chromium.org/738213002/diff/1/chrome/browser/ui/cocoa/exte...
File chrome/browser/ui/cocoa/extensions/browser_actions_controller.mm (right):

https://codereview.chromium.org/738213002/diff/1/chrome/browser/ui/cocoa/exte...
chrome/browser/ui/cocoa/extensions/browser_actions_controller.mm:737: nil];
On 2014/11/20 00:46:48, Avi wrote:
> NSDictionary* animationDictionary = @{
>   NSViewAnimationTargetKey : chevronMenuButton_.get(),
>   NSViewAnimationEffectKey : animationEffect
> };

ah, right, fancy new literals.  Done.

[Devlin, 2014-11-20 21:13:09]

The CQ bit was checked by rdevlin.cronin@chromium.org

[commit-bot: I haz the power, 2014-11-20 21:14:47]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/738213002/20001

[commit-bot: I haz the power, 2014-11-20 22:36:59]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2014-11-20 22:38:44]

Patchset 2 (id:??) landed as
https://crrev.com/f3dc55e3947548641b3a69dca33b1232b508b0b9
Cr-Commit-Position: refs/heads/master@{#305091}