Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(128)

Unified Diff: media/blink/buffered_data_source.h

Issue 738193002: Update BufferedDataSource class documentation. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | media/blink/buffered_data_source.cc » ('j') | media/blink/buffered_data_source.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: media/blink/buffered_data_source.h
diff --git a/media/blink/buffered_data_source.h b/media/blink/buffered_data_source.h
index fc462b84ef69cf070bb77fbe07c5e7648fcb585d..dea8275ac3a7ffa7ffcc038b5edfb665b17307e0 100644
--- a/media/blink/buffered_data_source.h
+++ b/media/blink/buffered_data_source.h
@@ -42,8 +42,9 @@ class MEDIA_EXPORT BufferedDataSourceHost {
// A data source capable of loading URLs and buffering the data using an
// in-memory sliding window.
//
-// BufferedDataSource must be created and initialized on the render thread
-// before being passed to other threads. It may be deleted on any thread.
+// BufferedDataSource is accessed from multiple threads, and it exposes WeakPtrs
+// for posting methods to be run on the main thread. It must therefore also be
+// deleted on the main thread.
Wez 2014/11/19 21:38:55 It doesn't look like it actually exposes WeakPtrs;
no sievers 2014/11/19 21:42:48 Done.
class MEDIA_EXPORT BufferedDataSource : public DataSource {
public:
// Used to specify video preload states. They are "hints" to the browser about
« no previous file with comments | « no previous file | media/blink/buffered_data_source.cc » ('j') | media/blink/buffered_data_source.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698