Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(118)

Issue 738163003: Revert of Fix regression in chrome_proxy tests caused by switching to typ. (Closed)

Created:
6 years, 1 month ago by tommycli
Modified:
6 years, 1 month ago
Reviewers:
Dirk Pranke, dtu, tonyg
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Revert of Fix regression in chrome_proxy tests caused by switching to typ. (patchset #1 id:1 of https://codereview.chromium.org/741823003/) Reason for revert: Sorry, this quick-fix didn't work: http://build.chromium.org/p/chromium.linux/builders/Android%20Tests/builds/16872 Original issue's description: > Fix regression in chrome_proxy tests caused by switching to typ. > > When I switched telemetry to use typ in #304878, I missed that > the chrome_proxy tests depended on the perf package as well. > > TBR=dtu@chromium.org, tonyg@chromium.org > NOTREECHECKS=true > NOTRY=true > BUG=388256 > > Committed: https://crrev.com/0bb7170445d0eb1be8a2215b7446c66e95345cc8 > Cr-Commit-Position: refs/heads/master@{#304901} TBR=dtu@chromium.org,tonyg@chromium.org,dpranke@chromium.org NOTREECHECKS=true NOTRY=true BUG=388256 Committed: https://crrev.com/d9497673eb93d0adda43aa04c40896850d9eeb5e Cr-Commit-Position: refs/heads/master@{#304932}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -2 lines) Patch
M tools/chrome_proxy/run_tests View 2 chunks +1 line, -2 lines 0 comments Download

Messages

Total messages: 10 (3 generated)
tommycli
Created Revert of Fix regression in chrome_proxy tests caused by switching to typ.
6 years, 1 month ago (2014-11-19 23:54:00 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/738163003/1
6 years, 1 month ago (2014-11-19 23:55:41 UTC) #2
tommycli
On 2014/11/19 23:55:41, I haz the power (commit-bot) wrote: > CQ is trying da patch. ...
6 years, 1 month ago (2014-11-19 23:56:57 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/738163003/1
6 years, 1 month ago (2014-11-20 00:00:20 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years, 1 month ago (2014-11-20 00:01:30 UTC) #8
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/d9497673eb93d0adda43aa04c40896850d9eeb5e Cr-Commit-Position: refs/heads/master@{#304932}
6 years, 1 month ago (2014-11-20 00:02:08 UTC) #9
Dirk Pranke
6 years, 1 month ago (2014-11-20 00:34:21 UTC) #10
Message was sent while issue was closed.
lgtm.

Powered by Google App Engine
This is Rietveld 408576698