Issue 738153003: Do not put D8 and TEST natives into the external snapshot.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 738153003: Do not put D8 and TEST natives into the external snapshot. (Closed)

Created:
6 years, 1 month ago by baixo

Modified:
6 years, 1 month ago

Reviewers:
baixo1, vogelheim

CC:
v8-dev

Base URL:
https://chromium.googlesource.com/v8/v8.git@master

Project:
v8

Visibility:
Public.

Do not put D8 and TEST natives into the external snapshot. D8 natives, in particular, will cause Windows static builds to not link due to another definition in the generated file d8-js.cc. BUG=421063 Committed: https://chromium.googlesource.com/v8/v8/+/04a0f383034350173fadc983efdf896ba58037f3

Created: 6 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+0 lines, -2 lines)			Patch
	M	src/natives-external.cc	View		1 chunk	+0 lines, -2 lines	0 comments	Download

Total messages: 7 (3 generated)

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/738153003/1

6 years, 1 month ago (2014-11-20 20:32:47 UTC) #6

Message was sent while issue was closed.

Committed patchset #1 (id:1)