Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(117)

Issue 738143002: Add flag to enable Dwarf exception handling on ARM (Closed)

Created:
6 years, 1 month ago by Derek Schuff
Modified:
6 years, 1 month ago
Reviewers:
Mark Seaborn, JF
CC:
native-client-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/native_client/pnacl-llvm.git@merge_35
Visibility:
Public.

Description

Add flag to enable Dwarf exception handling on ARM Previously EABI EH was disabled for NaCl but not explicitly disabled for Non-SFI mode. Some changes upstream for better ARM EHABI support caused EHABI unwind info to be unconditionally emitted (into the .ARM.exidx section) which has references to aeabi_ functions which we do not include in our compiler-rt. Introduce a flag to fully disable EHABI support for ARM (to be used by Non-SFI mode) and clean up the disabling of EHABI for SFI mode as well. R=jfb@chromium.org, mseaborn@chromium.org BUG= https://code.google.com/p/nativeclient/issues/detail?id=3930 Committed: https://gerrit.chromium.org/gerrit/gitweb?p=native_client/pnacl-llvm.git;a=commit;h=a9072baedea1fd8759ab9bd0ed0c0e2821bdba7c

Patch Set 1 #

Total comments: 2

Patch Set 2 : also !isTargetEHABICompatible for SFI NaCl #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -19 lines) Patch
M lib/Target/ARM/ARMSubtarget.h View 1 2 chunks +4 lines, -1 line 0 comments Download
M lib/Target/ARM/MCTargetDesc/ARMMCAsmInfo.h View 1 chunk +0 lines, -7 lines 0 comments Download
M lib/Target/ARM/MCTargetDesc/ARMMCAsmInfo.cpp View 3 chunks +13 lines, -1 line 0 comments Download
M lib/Target/ARM/MCTargetDesc/ARMMCTargetDesc.cpp View 2 chunks +2 lines, -10 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Derek Schuff
This patch is against the 3.5 branch. The driver will use the -arm-enable-dwarf-eh flag in ...
6 years, 1 month ago (2014-11-19 18:51:30 UTC) #1
JF
https://codereview.chromium.org/738143002/diff/1/lib/Target/ARM/ARMSubtarget.h File lib/Target/ARM/ARMSubtarget.h (right): https://codereview.chromium.org/738143002/diff/1/lib/Target/ARM/ARMSubtarget.h#newcode388 lib/Target/ARM/ARMSubtarget.h:388: !isTargetDarwin() && !isTargetWindows() && !EnableARMDwarfEH;//@LOCALMOD !isTargetNaCl() ?
6 years, 1 month ago (2014-11-19 19:32:05 UTC) #2
Derek Schuff
https://codereview.chromium.org/738143002/diff/1/lib/Target/ARM/ARMSubtarget.h File lib/Target/ARM/ARMSubtarget.h (right): https://codereview.chromium.org/738143002/diff/1/lib/Target/ARM/ARMSubtarget.h#newcode388 lib/Target/ARM/ARMSubtarget.h:388: !isTargetDarwin() && !isTargetWindows() && !EnableARMDwarfEH;//@LOCALMOD On 2014/11/19 19:32:05, JF ...
6 years, 1 month ago (2014-11-19 19:56:48 UTC) #3
JF
lgtm
6 years, 1 month ago (2014-11-20 18:42:18 UTC) #4
Derek Schuff
6 years, 1 month ago (2014-11-20 19:32:47 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
a9072baedea1fd8759ab9bd0ed0c0e2821bdba7c (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698