Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(829)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 738113003: Refactor RenderThemeChromiumDefault (Closed)

Created:
6 years, 1 month ago by rwlbuis
Modified:
6 years ago
Reviewers:
tkent, keishi, pdr.
CC:
blink-reviews, blink-reviews-rendering, zoltan1, pdr+renderingwatchlist_chromium.org, eae+blinkwatch, leviw+renderwatch, jchaffraix+rendering
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

Refactor RenderThemeChromiumDefault In order to remove the OS() checks in extraDefaultStyleSheet introduce a few RenderThemeChromiumDefault subclasses. Note that RenderThemeChromiumAndroid derives from RenderThemeChromiumLinux in order to include the linux specific stylesheet. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=185890

Patch Set 1 #

Patch Set 2 : Fix copyrights #

Patch Set 3 : Fix android build #

Total comments: 5

Patch Set 4 : Fix license and android #

Total comments: 4

Patch Set 5 : #

Patch Set 6 : FixGN build #

Unified diffs Side-by-side diffs Delta from patch set Stats (+108 lines, -28 lines) Patch
M Source/core/BUILD.gn View 1 2 3 4 5 1 chunk +10 lines, -2 lines 0 comments Download
M Source/core/core.gypi View 1 1 chunk +4 lines, -0 lines 0 comments Download
M Source/core/rendering/RenderThemeChromiumAndroid.cpp View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/rendering/RenderThemeChromiumDefault.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/rendering/RenderThemeChromiumDefault.cpp View 1 2 chunks +4 lines, -25 lines 0 comments Download
A Source/core/rendering/RenderThemeChromiumLinux.h View 1 2 3 4 1 chunk +20 lines, -0 lines 0 comments Download
A Source/core/rendering/RenderThemeChromiumLinux.cpp View 1 2 3 4 1 chunk +29 lines, -0 lines 0 comments Download
A Source/core/rendering/RenderThemeChromiumWin.h View 1 2 3 1 chunk +19 lines, -0 lines 0 comments Download
A Source/core/rendering/RenderThemeChromiumWin.cpp View 1 2 3 1 chunk +21 lines, -0 lines 0 comments Download

Messages

Total messages: 24 (11 generated)
rwlbuis
@tkent feel free to add a better reviewer if possible, most of this code seems ...
6 years, 1 month ago (2014-11-19 22:27:13 UTC) #5
tkent
keishi@ and I are appropriate reviewers for RenderTheme*. This change is ok. I wanted to ...
6 years, 1 month ago (2014-11-20 01:46:23 UTC) #7
tkent
https://codereview.chromium.org/738113003/diff/90001/Source/core/rendering/RenderThemeChromiumLinux.cpp File Source/core/rendering/RenderThemeChromiumLinux.cpp (right): https://codereview.chromium.org/738113003/diff/90001/Source/core/rendering/RenderThemeChromiumLinux.cpp#newcode1 Source/core/rendering/RenderThemeChromiumLinux.cpp:1: /* Please use Chromium style header. http://www.chromium.org/blink/coding-style#TOC-License https://codereview.chromium.org/738113003/diff/90001/Source/core/rendering/RenderThemeChromiumLinux.cpp#newcode39 Source/core/rendering/RenderThemeChromiumLinux.cpp:39: ...
6 years, 1 month ago (2014-11-20 01:53:27 UTC) #8
rwlbuis
On 2014/11/20 01:53:27, tkent wrote: > https://codereview.chromium.org/738113003/diff/90001/Source/core/rendering/RenderThemeChromiumLinux.cpp > File Source/core/rendering/RenderThemeChromiumLinux.cpp (right): > > https://codereview.chromium.org/738113003/diff/90001/Source/core/rendering/RenderThemeChromiumLinux.cpp#newcode1 > ...
6 years, 1 month ago (2014-11-20 21:44:04 UTC) #9
tkent
https://codereview.chromium.org/738113003/diff/110001/Source/core/core.gyp File Source/core/core.gyp (right): https://codereview.chromium.org/738113003/diff/110001/Source/core/core.gyp#newcode565 Source/core/core.gyp:565: ['include', 'rendering/RenderThemeChromiumDefault\\.cpp$'], I think this is unnecessary. core.gypi contains ...
6 years, 1 month ago (2014-11-21 01:22:37 UTC) #10
rwlbuis
On 2014/11/21 01:22:37, tkent wrote: > https://codereview.chromium.org/738113003/diff/110001/Source/core/core.gyp > File Source/core/core.gyp (right): > > https://codereview.chromium.org/738113003/diff/110001/Source/core/core.gyp#newcode565 > ...
6 years ago (2014-11-21 18:53:43 UTC) #12
tkent
lgtm
6 years ago (2014-11-22 00:28:29 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/738113003/150001
6 years ago (2014-11-22 00:29:29 UTC) #15
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_gn_rel on tryserver.blink (http://build.chromium.org/p/tryserver.blink/builders/linux_chromium_gn_rel/builds/17692)
6 years ago (2014-11-22 00:42:57 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/738113003/150001
6 years ago (2014-11-22 01:15:04 UTC) #19
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_gn_rel on tryserver.blink (http://build.chromium.org/p/tryserver.blink/builders/linux_chromium_gn_rel/builds/17697)
6 years ago (2014-11-22 01:22:59 UTC) #21
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/738113003/170001
6 years ago (2014-11-24 16:12:42 UTC) #23
commit-bot: I haz the power
6 years ago (2014-11-24 18:09:37 UTC) #24
Message was sent while issue was closed. 
Committed patchset #6 (id:170001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=185890

Powered by Google App Engine
This is Rietveld 408576698