Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(125)

Issue 7381003: Reenable map collection. (Closed)

Created:
9 years, 5 months ago by Vyacheslav Egorov (Chromium)
Modified:
9 years, 5 months ago
Reviewers:
Lasse Reichstein
CC:
v8-dev
Visibility:
Public.

Description

Reenable map collection. Fix bug in in-object property slack tracking that was causing poor RayTrace performance: initial maps should be reattached to SharedFunctionInfo object at the end of GC even if map collection is not enabled. Fix presubmit error in objects.cc R=lrn@chromium.org BUG= TEST= Committed: http://code.google.com/p/v8/source/detail?r=8662

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+34 lines, -5 lines) Patch
M src/mark-compact.h View 2 chunks +4 lines, -0 lines 1 comment Download
M src/mark-compact.cc View 7 chunks +28 lines, -4 lines 1 comment Download
M src/objects.cc View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 2 (0 generated)
Vyacheslav Egorov (Chromium)
9 years, 5 months ago (2011-07-14 21:42:27 UTC) #1
Lasse Reichstein
9 years, 5 months ago (2011-07-15 07:00:14 UTC) #2
LGTM

http://codereview.chromium.org/7381003/diff/1/src/mark-compact.cc
File src/mark-compact.cc (right):

http://codereview.chromium.org/7381003/diff/1/src/mark-compact.cc#newcode409
src/mark-compact.cc:409: // This will allow map transition tree to die from both
root and leaves.
"a map transition tree" or "map transition trees"?

http://codereview.chromium.org/7381003/diff/1/src/mark-compact.h
File src/mark-compact.h (right):

http://codereview.chromium.org/7381003/diff/1/src/mark-compact.h#newcode622
src/mark-compact.h:622: void ReattachInitialMaps();
Make a comment saying what the function does, and possibly when it's called.

Powered by Google App Engine
This is Rietveld 408576698