Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(16)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 738093002: Make debugger stepping work in Sky (Closed)

Created:
6 years, 1 month ago by yurys
Modified:
6 years, 1 month ago
Reviewers:
eseidel
CC:
mojo-reviews_chromium.org, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, esprehn, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org, ojan
Base URL:
https://github.com/domokit/mojo.git@master
Project:
mojo
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -2 lines) Patch
M sky/engine/core/inspector/inspector_backend_mojo.cc View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
yurys
Not sure if we should recreate RunLoop every time or just initialize it lazily but ...
6 years, 1 month ago (2014-11-19 15:52:56 UTC) #2
eseidel
lgtm
6 years, 1 month ago (2014-11-19 16:35:24 UTC) #4
eseidel
Sky unfortunately doesn't have a CQ yet, so you'll have to "git cl land" this ...
6 years, 1 month ago (2014-11-19 16:35:56 UTC) #5
commit-bot: I haz the power
Commit queue rejected this change because it did not recognize the base URL. Please commit ...
6 years, 1 month ago (2014-11-19 16:39:25 UTC) #7
yurys
6 years, 1 month ago (2014-11-19 16:52:57 UTC) #8
Message was sent while issue was closed. 
Committed patchset #1 (id:1) manually as
09848a62290d511abcfa30bac43c4c12c89da6c1 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698