Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(86)

Issue 738083002: Allow pictures to have a full bounds (Closed)

Created:
6 years, 1 month ago by reed1
Modified:
6 years, 1 month ago
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Project:
skia
Visibility:
Public.

Description

Allow pictures to have a full bounds This reverts commit 7c4cdd2c5b7b6c71fa0e7612594f7885f2dbf264. BUG=skia: Committed: https://skia.googlesource.com/skia/+/78e276889795454891cbba48ab11927968114953

Patch Set 1 #

Patch Set 2 : update dox #

Unified diffs Side-by-side diffs Delta from patch set Stats (+84 lines, -44 lines) Patch
M include/core/SkBBHFactory.h View 3 chunks +4 lines, -4 lines 0 comments Download
M include/core/SkCanvas.h View 1 chunk +1 line, -1 line 0 comments Download
M include/core/SkDevice.h View 2 chunks +7 lines, -0 lines 0 comments Download
M include/core/SkPicture.h View 2 chunks +5 lines, -6 lines 0 comments Download
M include/core/SkPictureRecorder.h View 1 2 chunks +10 lines, -5 lines 0 comments Download
M src/core/SkBBHFactory.cpp View 1 chunk +9 lines, -4 lines 0 comments Download
M src/core/SkCanvas.cpp View 3 chunks +10 lines, -5 lines 0 comments Download
M src/core/SkCanvasDrawable.cpp View 2 chunks +20 lines, -2 lines 0 comments Download
M src/core/SkPicture.cpp View 1 chunk +2 lines, -3 lines 0 comments Download
M src/core/SkPictureRecorder.cpp View 3 chunks +7 lines, -10 lines 0 comments Download
M src/core/SkRecorder.h View 1 chunk +2 lines, -1 line 0 comments Download
M src/core/SkRecorder.cpp View 1 chunk +6 lines, -2 lines 0 comments Download
M tests/PictureTest.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 9 (3 generated)
reed1
6 years, 1 month ago (2014-11-19 15:31:57 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/738083002/20001
6 years, 1 month ago (2014-11-19 15:53:39 UTC) #4
commit-bot: I haz the power
Note for Reviewers: The CQ is waiting for an approval. If you believe that the ...
6 years, 1 month ago (2014-11-19 15:53:40 UTC) #5
reed1
fixed legayc, SampleArc and comment. ptal
6 years, 1 month ago (2014-11-19 15:57:28 UTC) #6
f(malita)
lgtm
6 years, 1 month ago (2014-11-19 16:03:30 UTC) #8
commit-bot: I haz the power
6 years, 1 month ago (2014-11-19 16:04:39 UTC) #9
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/78e276889795454891cbba48ab11927968114953

Powered by Google App Engine
This is Rietveld 408576698