[ServiceWorker] support OPTIONS request for ServiceWorker [1/3 blink]

[ServiceWorker] support OPTIONS request for ServiceWorker [1/3 blink]

Currently we can't handle OPTIONS request in the ServiceWorker.

This check is done in content/browser/service_worker/service_worker_request_handler.cc.
But we should support OPTIONS request except for CORS preflight request.

This CL depends on https://codereview.chromium.org/726543008/.

[1/3] blink: https://codereview.chromium.org/738033002/
Set SkipServiceWorker flag for CORS preflight request.
[2/3] chromium: https://codereview.chromium.org/716083003/
Remove IsMethodSupportedForServiceWorker check in service_worker_request_handler.cc
[3/3] blink: https://codereview.chromium.org/743653002/
Cleanup and add update LayoutTest.

BUG=434660
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=185781

[horo, 2014-11-19 11:43:50]

Patchset #1 (id:1) has been deleted

[horo, 2014-11-19 11:43:55]

Patchset #1 (id:20001) has been deleted

[horo, 2014-11-19 12:43:10]

horo@chromium.org changed reviewers:
+ yhirano@chromium.org

[horo, 2014-11-19 12:43:11]

yhirano@
Could you please review this?

[yhirano, 2014-11-21 01:22:25]

https://codereview.chromium.org/738033002/diff/40001/Source/core/loader/Docum...
File Source/core/loader/DocumentThreadableLoader.cpp (right):

https://codereview.chromium.org/738033002/diff/40001/Source/core/loader/Docum...
Source/core/loader/DocumentThreadableLoader.cpp:134: // FIXME: Remove this after
the method check in ServiceWorkerRequestHandler is removed in chromium side.
Please wrap comments in 80 columns.

https://codereview.chromium.org/738033002/diff/40001/Source/core/loader/Docum...
Source/core/loader/DocumentThreadableLoader.cpp:137:
newRequest.setSkipServiceWorker(false);
What are you doing here?
It seems you create a request and just discard it after that.

[horo, 2014-11-21 01:43:19]

Patchset #2 (id:60001) has been deleted

[horo, 2014-11-21 02:05:13]

Patchset #2 (id:80001) has been deleted

[horo, 2014-11-21 02:49:00]

https://codereview.chromium.org/738033002/diff/40001/Source/core/loader/Docum...
File Source/core/loader/DocumentThreadableLoader.cpp (right):

https://codereview.chromium.org/738033002/diff/40001/Source/core/loader/Docum...
Source/core/loader/DocumentThreadableLoader.cpp:137:
newRequest.setSkipServiceWorker(false);
On 2014/11/21 01:22:25, yhirano wrote:
> What are you doing here?
> It seems you create a request and just discard it after that.

Sorry. They are not needed.
I forgot to remove them before uploading.

[yhirano, 2014-11-21 03:37:23]

lgtm

[horo, 2014-11-21 04:23:25]

horo@chromium.org changed reviewers:
+ mkwst@chromium.org

[horo, 2014-11-21 04:23:25]

mkwst@
Could you please review this?

[Mike West, 2014-11-21 08:24:41]

LGTM.

[horo, 2014-11-21 09:00:40]

The CQ bit was checked by horo@chromium.org

[commit-bot: I haz the power, 2014-11-21 09:01:31]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/738033002/100001

[commit-bot: I haz the power, 2014-11-21 10:12:46]

Committed patchset #2 (id:100001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=185781