Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(26)

Issue 737733002: [turbofan] Avoid useless zero-extension on arm64. (Closed)

Created:
6 years, 1 month ago by baptiste.afsa1
Modified:
6 years, 1 month ago
Reviewers:
Benedikt Meurer
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Project:
v8
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : avoid using GetMachineType() #

Unified diffs Side-by-side diffs Delta from patch set Stats (+35 lines, -1 line) Patch
M src/compiler/arm64/instruction-selector-arm64.cc View 1 1 chunk +35 lines, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
baptiste.afsa1
PTAL
6 years, 1 month ago (2014-11-18 11:21:55 UTC) #1
Benedikt Meurer
Please don't use GetMachineType(), it's not going to stay and probably wrong anyway.
6 years, 1 month ago (2014-11-19 08:00:23 UTC) #2
baptiste.afsa1
On 2014/11/19 08:00:23, Benedikt Meurer wrote: > Please don't use GetMachineType(), it's not going to ...
6 years, 1 month ago (2014-11-20 13:41:44 UTC) #3
Benedikt Meurer
LGTM. Thanks.
6 years, 1 month ago (2014-11-21 05:12:38 UTC) #4
baptiste.afsa1
6 years, 1 month ago (2014-11-21 10:01:04 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
fada2a08e561510a5c1e440eed28fdfa5ffa6d81 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698