drawinfo carries bufferinfo

include/gpu/GrGpuResourceRef.h

 /*
  * Copyright 2014 Google Inc.
  *
  * Use of this source code is governed by a BSD-style license that can be
  * found in the LICENSE file.
  */
 
 #ifndef GrGpuResourceRef_DEFINED
 #define GrGpuResourceRef_DEFINED
 
@@ skipping 141 matching lines @@
 private:
     typedef GrGpuResourceRef INHERITED;
 };
 
 /**
  * This is similar to GrTGpuResourceRef but can only be in the pending IO state. It never owns a
  * ref.
  */
 template <typename T, GrIOType IO_TYPE> class GrPendingIOResource : SkNoncopyable {
 public:
-    GrPendingIOResource(T* resource) : fResource(resource) {
-        if (NULL != fResource) {
+    GrPendingIOResource(T* resource = NULL) : fResource(NULL) {
+        this->reset(resource);
+    }
+
+    void reset(T* resource) {
+        if (resource) {
             switch (IO_TYPE) {
                 case kRead_GrIOType:
-                    fResource->addPendingRead();
+                    resource->addPendingRead();
                     break;
                 case kWrite_GrIOType:
-                    fResource->addPendingWrite();
+                    resource->addPendingWrite();
                     break;
                 case kRW_GrIOType:
-                    fResource->addPendingRead();
-                    fResource->addPendingWrite();
+                    resource->addPendingRead();
+                    resource->addPendingWrite();
                     break;
             }
         }
+        if (fResource) {

[bsalomon, 2014/11/18 22:05:27]

why not just this->release(), since it does the check.

otherwise, lgtm.

+            this->release();
+        }
+        fResource = resource;
     }
 
     ~GrPendingIOResource() {
-        if (NULL != fResource) {
+        this->release();
+    }
+
+    T* get() const { return fResource; }
+
+private:
+    void release() {
+        if (fResource) {
             switch (IO_TYPE) {
                 case kRead_GrIOType:
                     fResource->completedRead();
                     break;
                 case kWrite_GrIOType:
                     fResource->completedWrite();
                     break;
                 case kRW_GrIOType:
                     fResource->completedRead();
                     fResource->completedWrite();
                     break;
             }
         }
     }
 
-    T* get() const { return fResource; }
-
-private:
     T* fResource;
 };
 #endif