Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(611)

Issue 737653003: [NaCl SDK] Remove create_nmf dependency on NACL_SDK_ROOT env var (Closed)

Created:
6 years, 1 month ago by Sam Clegg
Modified:
5 years, 10 months ago
CC:
chromium-reviews, binji+watch_chromium.org, Sam Clegg
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[NaCl SDK] Remove create_nmf dependency on NACL_SDK_ROOT env var create_nmf should determine the root of the SDK relative to its own location. The exception to this is when its run as part of the chrome build, when it is not yet installed. In this case we pass --no-default-libpath and --objdump to create_nmf to remove any use of the SDK root. Committed: https://crrev.com/088561ac99314a79866a39f79bb32bd5e1196217 Cr-Commit-Position: refs/heads/master@{#313957}

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : #

Patch Set 5 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+39 lines, -39 lines) Patch
M native_client_sdk/src/tools/create_nmf.py View 1 2 3 4 5 chunks +13 lines, -20 lines 0 comments Download
M native_client_sdk/src/tools/tests/create_nmf_test.py View 1 2 chunks +11 lines, -15 lines 0 comments Download
M ppapi/ppapi_nacl.gyp View 1 2 3 4 6 chunks +8 lines, -2 lines 0 comments Download
M ppapi/ppapi_nacl_test_common.gypi View 1 2 3 4 5 chunks +7 lines, -2 lines 0 comments Download

Messages

Total messages: 19 (7 generated)
Sam Clegg
6 years, 1 month ago (2014-11-18 00:35:15 UTC) #2
binji
nice! lgtm
6 years, 1 month ago (2014-11-18 00:39:54 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/737653003/40001
6 years, 1 month ago (2014-11-18 18:14:08 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/24933)
6 years, 1 month ago (2014-11-18 18:17:53 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/737653003/80001
5 years, 10 months ago (2015-01-30 01:22:44 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/39342)
5 years, 10 months ago (2015-01-30 01:29:45 UTC) #11
Sam Clegg
+dmichael for ppapi/
5 years, 10 months ago (2015-01-30 01:46:50 UTC) #13
dmichael (off chromium)
ppapi lgtm
5 years, 10 months ago (2015-01-30 16:28:51 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/737653003/80001
5 years, 10 months ago (2015-01-30 19:07:24 UTC) #16
commit-bot: I haz the power
Committed patchset #5 (id:80001)
5 years, 10 months ago (2015-01-30 19:12:00 UTC) #17
commit-bot: I haz the power
Patchset 5 (id:??) landed as https://crrev.com/088561ac99314a79866a39f79bb32bd5e1196217 Cr-Commit-Position: refs/heads/master@{#313957}
5 years, 10 months ago (2015-01-30 19:14:31 UTC) #18
please use gerrit instead
5 years, 10 months ago (2015-01-30 19:34:32 UTC) #19
Message was sent while issue was closed.
A revert of this CL (patchset #5 id:80001) has been created in
https://codereview.chromium.org/890033003/ by rouslan@chromium.org.

The reason for reverting is: Broke compile on Google Chrome ChromeOS bot.

[8069/19495] CXX
obj/components/policy/core/common/cloud/policy_component_common.external_policy_data_updater.o
FAILED: cd ../../third_party/liblouis; python
../../native_client_sdk/src/tools/create_nmf.py
../../out/Release/chromevox_test_data/braille/liblouis_nacl_x86_64.nexe
"--output=../../out/Release/chromevox_test_data/braille/liblouis_nacl.nmf"
Traceback (most recent call last):
  File "../../native_client_sdk/src/tools/create_nmf.py", line 680, in <module>
    rtn = main(sys.argv[1:])
  File "../../native_client_sdk/src/tools/create_nmf.py", line 633, in main
    options.lib_path += GetDefaultLibPath(config)
  File "../../native_client_sdk/src/tools/create_nmf.py", line 507, in
GetDefaultLibPath
    sdk_root = GetSDKRoot()
  File "../../native_client_sdk/src/tools/create_nmf.py", line 478, in
GetSDKRoot
    assert(os.path.exists(os.path.join(sdk_root, 'toolchain')))
AssertionError
ninja: build stopped: subcommand failed.

http://build.chromium.org/p/chromium.chrome/builders/Google%20Chrome%20Chrome....

Powered by Google App Engine
This is Rietveld 408576698