base/BUILD.gn - Issue 737633002: Fix various flags in the Win64 GN build

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: base/BUILD.gn

Issue 737633002: Fix various flags in the Win64 GN build (Closed) Base URL: http://chromium.googlesource.com/chromium/src.git@master

Patch Set: tweak more flags to better match GYP Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: base/BUILD.gn

diff --git a/base/BUILD.gn b/base/BUILD.gn

index 2fc232d6c41cec5fd4a1d020d72afe26ae185f0d..959d4629a80a707a9c3609de9f05318d93c66473 100644

--- a/base/BUILD.gn

+++ b/base/BUILD.gn

@@ -1403,6 +1403,11 @@ test("base_unittests") {

sources += [ "debug/proc_maps_linux_unittest.cc" ]

set_sources_assignment_filter(sources_assignment_filter)

}

+ if (is_win) {

+ # TODO(jschuh): crbug.com/167187 fix size_t to int truncations.

+ cflags = [ "/wd4267" ]

+ }

}

if (is_android) {