Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(266)

Unified Diff: sky/engine/core/frame/FrameView.cpp

Issue 737523002: Sky: Move iframe geometry updates to FrameView::updateLayout instead of (Closed) Base URL: git@github.com:domokit/mojo.git@master
Patch Set: . Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « sky/engine/core/frame/FrameView.h ('k') | sky/engine/core/rendering/RenderIFrame.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sky/engine/core/frame/FrameView.cpp
diff --git a/sky/engine/core/frame/FrameView.cpp b/sky/engine/core/frame/FrameView.cpp
index 4c658feee7d9beb2b6e4cec211db8c926ae0ad49..af2da1afa010ec11c74776f19c1c3a87ba521c5d 100644
--- a/sky/engine/core/frame/FrameView.cpp
+++ b/sky/engine/core/frame/FrameView.cpp
@@ -958,6 +958,7 @@ void FrameView::updateLayoutAndStyleForPainting()
RefPtr<FrameView> protector(this);
updateLayoutAndStyleIfNeededRecursive();
+ updateIFramesAfterLayout();
if (RenderView* view = renderView()) {
TRACE_EVENT_INSTANT1(TRACE_DISABLED_BY_DEFAULT("devtools.timeline"), "UpdateLayerTree", TRACE_EVENT_SCOPE_PROCESS, "frame", m_frame.get());
@@ -1118,4 +1119,20 @@ void FrameView::setLayoutSizeInternal(const IntSize& size)
contentsResized();
}
+void FrameView::addIFrame(RenderIFrame* iframe)
+{
+ m_iframes.add(iframe);
+}
+
+void FrameView::removeIFrame(RenderIFrame* iframe)
+{
+ m_iframes.remove(iframe);
esprehn 2014/11/17 20:07:49 I don't think you need this change, we should trac
Matt Perry 2014/11/17 20:18:17 Done.
+}
+
+void FrameView::updateIFramesAfterLayout()
+{
+ for (auto& iframe: m_iframes)
+ iframe->updateWidgetBounds();
+}
+
} // namespace blink
« no previous file with comments | « sky/engine/core/frame/FrameView.h ('k') | sky/engine/core/rendering/RenderIFrame.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698