src/assembler_ia32.cpp - Issue 737513008: Subzero: Simplify the constant pools.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/assembler_ia32.cpp

Issue 737513008: Subzero: Simplify the constant pools. (Closed) Base URL: https://chromium.googlesource.com/native_client/pnacl-subzero.git@master

Patch Set: Better fix for the int8/uint8 tests Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/assembler_ia32.cpp

diff --git a/src/assembler_ia32.cpp b/src/assembler_ia32.cpp

index 8857a57cdce6b9040dc57d6b98d7a8452dbae398..94263e8bd94aa7cbbe83e55da6204b370ed12e12 100644

--- a/src/assembler_ia32.cpp

+++ b/src/assembler_ia32.cpp

@@ -60,8 +60,7 @@ Address Address::ofConstPool(GlobalContext *Ctx, Assembler *Asm,

StrBuf << ".L$" << Ty << "$" << Imm->getPoolEntryID();

const RelocOffsetT Offset = 0;

const bool SuppressMangling = true;

- Constant *Sym =

- Ctx->getConstantSym(Ty, Offset, StrBuf.str(), SuppressMangling);

+ Constant *Sym = Ctx->getConstantSym(Offset, StrBuf.str(), SuppressMangling);

AssemblerFixup *Fixup = x86::DisplacementRelocation::create(

Asm, FK_Abs_4, llvm::cast<ConstantRelocatable>(Sym));

return x86::Address::Absolute(Fixup);

« no previous file with comments | « src/PNaClTranslator.cpp ('k') | tests_lit/llvm2ice_tests/undef.ll » ('j') | no next file with comments »