Subzero: Simplify the constant pools.

src/IceGlobalContext.h

Index: src/IceGlobalContext.h
diff --git a/src/IceGlobalContext.h b/src/IceGlobalContext.h
index 43f65ad8fe8a747cfddb85b2a0dd7faac3f59e18..42c119a6071bd5b487e21ce1dd42499b7b62a2b4 100644
--- a/src/IceGlobalContext.h
+++ b/src/IceGlobalContext.h
@@ -113,14 +113,16 @@ public:
   // Manage Constants.
   // getConstant*() functions are not const because they might add
   // something to the constant pool.
-  Constant *getConstantInt32(Type Ty, uint32_t ConstantInt32);

[Karl, 2014/11/19 18:45:28]

Why not have a version of this defined here (with the corresponding switch),
rather than force callers to do this.

[Jim Stichnoth, 2014/11/20 00:08:57]

Done, see the new getConstantInt() method.

-  Constant *getConstantInt64(Type Ty, uint64_t ConstantInt64);
+  Constant *getConstantInt1(int8_t ConstantInt1);
+  Constant *getConstantInt8(int8_t ConstantInt8);
+  Constant *getConstantInt16(int16_t ConstantInt16);
+  Constant *getConstantInt32(int32_t ConstantInt32);
+  Constant *getConstantInt64(int64_t ConstantInt64);
   Constant *getConstantFloat(float Value);
   Constant *getConstantDouble(double Value);
   // Returns a symbolic constant.
-  Constant *getConstantSym(Type Ty, RelocOffsetT Offset,
-                           const IceString &Name = "",
-                           bool SuppressMangling = false);
+  Constant *getConstantSym(RelocOffsetT Offset, const IceString &Name,
+                           bool SuppressMangling);
   // Returns an undef.
   Constant *getConstantUndef(Type Ty);
   // Returns a zero value.