Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(50)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 737493002: Remove DEPS from sky (Closed)

Created:
6 years, 1 month ago by eseidel
Modified:
6 years, 1 month ago
Reviewers:
jamesr, abarth-chromium
CC:
abarth-chromium, esprehn, mojo-reviews_chromium.org, ojan
Base URL:
git@github.com:domokit/mojo.git@master
Project:
mojo
Visibility:
Public.

Description

Remove DEPS from sky Also taught PRESUBMIT.py how to ignore DEPS for sky/ since gn check already covers everything we were using DEPS for. R=abarth@chromium.org, jamesr@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/fbd0bb92cf0d8e213e4b31d43ffdd420576c200e

Patch Set 1 #

Patch Set 2 : No need for the PRESUBMIT.py change #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -118 lines) Patch
M DEPS View 1 1 chunk +1 line, -0 lines 0 comments Download
D sky/engine/DEPS View 1 chunk +0 lines, -7 lines 0 comments Download
D sky/engine/bindings/DEPS View 1 chunk +0 lines, -10 lines 0 comments Download
D sky/engine/core/DEPS View 1 chunk +0 lines, -9 lines 0 comments Download
D sky/engine/platform/DEPS View 1 chunk +0 lines, -17 lines 0 comments Download
D sky/engine/public/DEPS View 1 chunk +0 lines, -4 lines 0 comments Download
D sky/engine/public/platform/DEPS View 1 chunk +0 lines, -5 lines 0 comments Download
D sky/engine/public/platform/linux/DEPS View 1 chunk +0 lines, -3 lines 0 comments Download
D sky/engine/public/web/DEPS View 1 chunk +0 lines, -9 lines 0 comments Download
D sky/engine/public/web/android/DEPS View 1 chunk +0 lines, -3 lines 0 comments Download
D sky/engine/web/DEPS View 1 chunk +0 lines, -18 lines 0 comments Download
D sky/services/inspector/DEPS View 1 chunk +0 lines, -6 lines 0 comments Download
D sky/tools/debugger/DEPS View 1 chunk +0 lines, -5 lines 0 comments Download
D sky/tools/tester/DEPS View 1 chunk +0 lines, -5 lines 0 comments Download
D sky/viewer/DEPS View 1 chunk +0 lines, -14 lines 0 comments Download
D sky/viewer/cc/DEPS View 1 chunk +0 lines, -3 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
eseidel
6 years, 1 month ago (2014-11-17 18:56:02 UTC) #1
abarth-chromium
lgtm
6 years, 1 month ago (2014-11-17 19:14:29 UTC) #3
eseidel
Committed patchset #2 (id:20001) manually as fbd0bb92cf0d8e213e4b31d43ffdd420576c200e (presubmit successful).
6 years, 1 month ago (2014-11-17 19:16:48 UTC) #4
jamesr
6 years, 1 month ago (2014-11-17 19:17:45 UTC) #5
Message was sent while issue was closed. 
Woohoo!

Powered by Google App Engine
This is Rietveld 408576698