[Telemetry] Move more browser specific logic to shared_page_state

[Telemetry] Move more browser specific logic to shared_page_state

BUG=418278
Committed: https://crrev.com/9061968a7fef87e9f9266dbe629e3f14bb4b017f
Cr-Commit-Position: refs/heads/master@{#304469}

[nednguyen, 2014-11-17 18:10:22]

nednguyen@google.com changed reviewers:
+ chrishenry@google.com, dtu@chromium.org, tonyg@chromium.org

[tonyg, 2014-11-17 18:35:10]

lgtm w/ nits

https://codereview.chromium.org/737463002/diff/1/tools/telemetry/telemetry/pa...
File tools/telemetry/telemetry/page/page_runner.py (right):

https://codereview.chromium.org/737463002/diff/1/tools/telemetry/telemetry/pa...
tools/telemetry/telemetry/page/page_runner.py:94: assert skip_value
We probably want an error message w/ this assert.

https://codereview.chromium.org/737463002/diff/1/tools/telemetry/telemetry/pa...
File tools/telemetry/telemetry/page/shared_page_state.py (right):

https://codereview.chromium.org/737463002/diff/1/tools/telemetry/telemetry/pa...
tools/telemetry/telemetry/page/shared_page_state.py:9: from telemetry.core
import browser_info
alphabetize

https://codereview.chromium.org/737463002/diff/1/tools/telemetry/telemetry/pa...
tools/telemetry/telemetry/page/shared_page_state.py:60: self._StopProfiling()
I think we want to stop profiling before doing all the above cleanup work. It
doesn't seem to belong in the profile.

[nednguyen, 2014-11-17 19:38:00]

https://codereview.chromium.org/737463002/diff/1/tools/telemetry/telemetry/pa...
File tools/telemetry/telemetry/page/page_runner.py (right):

https://codereview.chromium.org/737463002/diff/1/tools/telemetry/telemetry/pa...
tools/telemetry/telemetry/page/page_runner.py:94: assert skip_value
On 2014/11/17 18:35:10, tonyg wrote:
> We probably want an error message w/ this assert.

results.AddValue(skip_value) does display skip_value's reason in
gtest_progress_reporter.

https://codereview.chromium.org/737463002/diff/1/tools/telemetry/telemetry/pa...
File tools/telemetry/telemetry/page/shared_page_state.py (right):

https://codereview.chromium.org/737463002/diff/1/tools/telemetry/telemetry/pa...
tools/telemetry/telemetry/page/shared_page_state.py:9: from telemetry.core
import browser_info
On 2014/11/17 18:35:10, tonyg wrote:
> alphabetize

Done.

https://codereview.chromium.org/737463002/diff/1/tools/telemetry/telemetry/pa...
tools/telemetry/telemetry/page/shared_page_state.py:60: self._StopProfiling()
On 2014/11/17 18:35:10, tonyg wrote:
> I think we want to stop profiling before doing all the above cleanup work. It
> doesn't seem to belong in the profile.

Done.

https://codereview.chromium.org/737463002/diff/1/tools/telemetry/telemetry/pa...
tools/telemetry/telemetry/page/shared_page_state.py:60: self._StopProfiling()
On 2014/11/17 18:35:10, tonyg wrote:
> I think we want to stop profiling before doing all the above cleanup work. It
> doesn't seem to belong in the profile.

Done.

[nednguyen, 2014-11-17 19:38:31]

The CQ bit was checked by nednguyen@google.com

[commit-bot: I haz the power, 2014-11-17 19:39:06]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/737463002/20001

[commit-bot: I haz the power, 2014-11-17 20:43:19]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2014-11-17 20:44:03]

Patchset 2 (id:??) landed as
https://crrev.com/9061968a7fef87e9f9266dbe629e3f14bb4b017f
Cr-Commit-Position: refs/heads/master@{#304469}