tools/perf/measurements/screenshot_unittest.py - Issue 737403002: Revert of telemetry: Remove command line args from page test

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/perf/measurements/screenshot_unittest.py

Issue 737403002: Revert of telemetry: Remove command line args from page test (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: tools/perf/measurements/screenshot_unittest.py

diff --git a/tools/perf/measurements/screenshot_unittest.py b/tools/perf/measurements/screenshot_unittest.py

index b06f9c87d5201a73ad97fc7f2ca9ecac6fbf8b87..379adbc57f82d5037d31dc5b864f3d386f6e00a9 100644

--- a/tools/perf/measurements/screenshot_unittest.py

+++ b/tools/perf/measurements/screenshot_unittest.py

@@ -15,15 +15,15 @@

class ScreenshotUnitTest(page_test_test_case.PageTestTestCase):

def setUp(self):

self._options = options_for_unittests.GetCopy()

- self._png_outdir = tempfile.mkdtemp('_png_test')

+ self._options.png_outdir = tempfile.mkdtemp('_png_test')

def tearDown(self):

- shutil.rmtree(self._png_outdir)

+ shutil.rmtree(self._options.png_outdir)

@benchmark.Disabled('win') # http://crbug.com/386572

def testScreenshot(self):

ps = self.CreatePageSetFromFileInUnittestDataDir('blank.html')

- measurement = screenshot.Screenshot(self._png_outdir)

+ measurement = screenshot.Screenshot()

results = self.RunMeasurement(measurement, ps, options=self._options)

if results.failures:

logging.warning(str(results.failures))

« no previous file with comments | « tools/perf/measurements/screenshot.py ('k') | tools/perf/measurements/session_restore.py » ('j') | no next file with comments »