Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(51)

Unified Diff: tools/perf/benchmarks/repaint.py

Issue 737403002: Revert of telemetry: Remove command line args from page test (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tools/perf/benchmarks/rasterize_and_record_micro.py ('k') | tools/perf/benchmarks/session_restore.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/perf/benchmarks/repaint.py
diff --git a/tools/perf/benchmarks/repaint.py b/tools/perf/benchmarks/repaint.py
index df9a1bb939dab78cdf54c785bd8f13ac05a97762..0b41f4c576978283bc6d71ba61e3056e7a669273 100644
--- a/tools/perf/benchmarks/repaint.py
+++ b/tools/perf/benchmarks/repaint.py
@@ -3,44 +3,28 @@
# found in the LICENSE file.
from benchmarks import silk_flags
-from measurements import repaint as repaint_measurement
+from measurements import repaint
import page_sets
from telemetry import benchmark
-class _Repaint(benchmark.Benchmark):
- @classmethod
- def AddBenchmarkCommandLineArgs(cls, parser):
- parser.add_option('--mode', type='string',
- default='viewport',
- help='Invalidation mode. '
- 'Supported values: fixed_size, layer, random, viewport.')
- parser.add_option('--width', type='int',
- default=None,
- help='Width of invalidations for fixed_size mode.')
- parser.add_option('--height', type='int',
- default=None,
- help='Height of invalidations for fixed_size mode.')
-
- def CreatePageTest(self, options):
- return repaint_measurement.Repaint(options.mode, options.width,
- options.height)
-
@benchmark.Enabled('android')
-class RepaintKeyMobileSites(_Repaint):
+class RepaintKeyMobileSites(benchmark.Benchmark):
"""Measures repaint performance on the key mobile sites.
http://www.chromium.org/developers/design-documents/rendering-benchmarks"""
+ test = repaint.Repaint
page_set = page_sets.KeyMobileSitesPageSet
@benchmark.Enabled('android')
-class RepaintGpuRasterizationKeyMobileSites(_Repaint):
+class RepaintGpuRasterizationKeyMobileSites(benchmark.Benchmark):
"""Measures repaint performance on the key mobile sites with forced GPU
rasterization.
http://www.chromium.org/developers/design-documents/rendering-benchmarks"""
tag = 'gpu_rasterization'
+ test = repaint.Repaint
page_set = page_sets.KeyMobileSitesPageSet
def CustomizeBrowserOptions(self, options):
silk_flags.CustomizeBrowserOptionsForGpuRasterization(options)
« no previous file with comments | « tools/perf/benchmarks/rasterize_and_record_micro.py ('k') | tools/perf/benchmarks/session_restore.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698