Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(135)

Unified Diff: tools/perf/measurements/skpicture_printer.py

Issue 737403002: Revert of telemetry: Remove command line args from page test (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tools/perf/measurements/skpicture_printer.py
diff --git a/tools/perf/measurements/skpicture_printer.py b/tools/perf/measurements/skpicture_printer.py
index fd41e67ddc6844248327875f66078f1ddbe296da..687cf0cd4d7caa1cc73c5b7bdd7337ffa115ad06 100644
--- a/tools/perf/measurements/skpicture_printer.py
+++ b/tools/perf/measurements/skpicture_printer.py
@@ -12,9 +12,16 @@
class SkpicturePrinter(page_test.PageTest):
- def __init__(self, skp_outdir):
- super(SkpicturePrinter, self).__init__()
- self._skp_outdir = skp_outdir
+ @classmethod
+ def AddCommandLineArgs(cls, parser):
+ parser.add_option('-s', '--skp-outdir',
+ help='Output directory for the SKP files')
+
+ @classmethod
+ def ProcessCommandLineArgs(cls, parser, args):
+ if not args.skp_outdir:
+ parser.error('Please specify --skp-outdir')
+ cls._skp_outdir = args.skp_outdir
def CustomizeBrowserOptions(self, options):
options.AppendExtraBrowserArgs(['--enable-gpu-benchmarking',
« no previous file with comments | « tools/perf/measurements/session_restore_with_url.py ('k') | tools/perf/measurements/skpicture_printer_unittest.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698