tools/perf/benchmarks/benchmark_smoke_unittest.py - Issue 737403002: Revert of telemetry: Remove command line args from page test

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/perf/benchmarks/benchmark_smoke_unittest.py

Issue 737403002: Revert of telemetry: Remove command line args from page test (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: tools/perf/benchmarks/benchmark_smoke_unittest.py

diff --git a/tools/perf/benchmarks/benchmark_smoke_unittest.py b/tools/perf/benchmarks/benchmark_smoke_unittest.py

index bed257ebb9736c0a777a899a4fc23aed7018d43f..a3828616c33808f26c13ca1919f5df26fdd147db 100644

--- a/tools/perf/benchmarks/benchmark_smoke_unittest.py

+++ b/tools/perf/benchmarks/benchmark_smoke_unittest.py

@@ -77,8 +77,8 @@

benchmarks_dir, top_level_dir, benchmark_module.Benchmark,

index_by_class_name=False).values()

for benchmark in all_benchmarks:

- if hasattr(benchmark, 'test') and benchmark.test not in all_measurements:

- # If the benchmark does not have a measurement, then it is not composable.

+ if benchmark.PageTestClass() not in all_measurements:

+ # If the benchmark is not in measurements, then it is not composable.

# Ideally we'd like to test these as well, but the non-composable

# benchmarks are usually long-running benchmarks.

continue

« no previous file with comments | « content/test/gpu/gpu_tests/webgl_conformance.py ('k') | tools/perf/benchmarks/page_cycler.py » ('j') | no next file with comments »