Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(174)

Side by Side Diff: tools/perf/measurements/thread_times_unittest.py

Issue 737403002: Revert of telemetry: Remove command line args from page test (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « tools/perf/measurements/thread_times.py ('k') | tools/telemetry/telemetry/benchmark.py » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright 2014 The Chromium Authors. All rights reserved. 1 # Copyright 2014 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 from measurements import thread_times 5 from measurements import thread_times
6 from measurements import smoothness_unittest 6 from measurements import smoothness_unittest
7 from metrics import timeline 7 from metrics import timeline
8 from telemetry.core import wpr_modes 8 from telemetry.core import wpr_modes
9 from telemetry.unittest_util import options_for_unittests 9 from telemetry.unittest_util import options_for_unittests
10 from telemetry.unittest_util import page_test_test_case 10 from telemetry.unittest_util import page_test_test_case
(...skipping 28 matching lines...) Expand all
39 results = self.RunMeasurement(measurement, ps, options = timeline_options) 39 results = self.RunMeasurement(measurement, ps, options = timeline_options)
40 self.assertEquals(0, len(results.failures)) 40 self.assertEquals(0, len(results.failures))
41 41
42 for category in timeline.TimelineThreadCategories.values(): 42 for category in timeline.TimelineThreadCategories.values():
43 cpu_time_name = timeline.ThreadCpuTimeResultName(category) 43 cpu_time_name = timeline.ThreadCpuTimeResultName(category)
44 cpu_time = results.FindAllPageSpecificValuesNamed(cpu_time_name) 44 cpu_time = results.FindAllPageSpecificValuesNamed(cpu_time_name)
45 self.assertEquals(len(cpu_time), 1) 45 self.assertEquals(len(cpu_time), 1)
46 46
47 def testWithSilkDetails(self): 47 def testWithSilkDetails(self):
48 ps = self.CreatePageSetFromFileInUnittestDataDir('scrollable_page.html') 48 ps = self.CreatePageSetFromFileInUnittestDataDir('scrollable_page.html')
49 measurement = thread_times.ThreadTimes(report_silk_details=True) 49 measurement = thread_times.ThreadTimes()
50 self._options.report_silk_details = True
50 results = self.RunMeasurement(measurement, ps, options = self._options) 51 results = self.RunMeasurement(measurement, ps, options = self._options)
51 self.assertEquals(0, len(results.failures)) 52 self.assertEquals(0, len(results.failures))
52 53
53 main_thread = "renderer_main" 54 main_thread = "renderer_main"
54 expected_trace_categories = ["blink", "cc", "idle"] 55 expected_trace_categories = ["blink", "cc", "idle"]
55 for trace_category in expected_trace_categories: 56 for trace_category in expected_trace_categories:
56 value_name = timeline.ThreadDetailResultName(main_thread, trace_category) 57 value_name = timeline.ThreadDetailResultName(main_thread, trace_category)
57 values = results.FindAllPageSpecificValuesNamed(value_name) 58 values = results.FindAllPageSpecificValuesNamed(value_name)
58 self.assertEquals(len(values), 1) 59 self.assertEquals(len(values), 1)
59 60
60 def testCleanUpTrace(self): 61 def testCleanUpTrace(self):
61 self.TestTracingCleanedUp(thread_times.ThreadTimes, self._options) 62 self.TestTracingCleanedUp(thread_times.ThreadTimes, self._options)
OLDNEW
« no previous file with comments | « tools/perf/measurements/thread_times.py ('k') | tools/telemetry/telemetry/benchmark.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698