pkg/compiler/lib/src/cps_ir/redundant_phi.dart - Issue 737353002: cps-ir: Implement boolean conversion in and use it to implement '&&', '||', and '?:'.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: pkg/compiler/lib/src/cps_ir/redundant_phi.dart

Issue 737353002: cps-ir: Implement boolean conversion in and use it to implement '&&', '||', and '?:'. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« pkg/compiler/lib/src/cps_ir/cps_ir_tracer.dart ('K') | « pkg/compiler/lib/src/cps_ir/cps_ir_tracer.dart ('k') | pkg/compiler/lib/src/cps_ir/shrinking_reductions.dart » ('j') | pkg/compiler/lib/src/js_backend/codegen/unsugar.dart » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: pkg/compiler/lib/src/cps_ir/redundant_phi.dart

diff --git a/pkg/compiler/lib/src/cps_ir/redundant_phi.dart b/pkg/compiler/lib/src/cps_ir/redundant_phi.dart

index 11c6bf088639f5cec3a10c03f617c2b38ce994ac..f297a37ba42eda1d3cbdfea1894b12229f6ebc61 100644

--- a/pkg/compiler/lib/src/cps_ir/redundant_phi.dart

+++ b/pkg/compiler/lib/src/cps_ir/redundant_phi.dart

@@ -19,7 +19,7 @@ class RedundantPhiEliminator extends RecursiveVisitor implements Pass {

if (root.isAbstract) return;

// Set all parent pointers.

- new _ParentVisitor().visit(root);

+ new ParentVisitor().visit(root);

// Traverse the tree once to build the work set.

visit(root);