Source/core/rendering/BidiRunForLine.cpp - Issue 737333002: Ignore pos argument if the first render object is not the current one.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/rendering/BidiRunForLine.cpp

Issue 737333002: Ignore pos argument if the first render object is not the current one. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/core/rendering/BidiRunForLine.cpp

diff --git a/Source/core/rendering/BidiRunForLine.cpp b/Source/core/rendering/BidiRunForLine.cpp

index 9032966f7090d6e580bb424ef55d18c423062721..bc0ae637cdeee37dcb005fe91a0eed3862b4ef05 100644

--- a/Source/core/rendering/BidiRunForLine.cpp

+++ b/Source/core/rendering/BidiRunForLine.cpp

@@ -83,8 +83,9 @@ static RenderObject* firstRenderObjectForDirectionalityDetermination(

TextDirection determinePlaintextDirectionality(RenderObject* root,

RenderObject* current = 0, unsigned pos = 0)

{

- InlineIterator iter(root,

- firstRenderObjectForDirectionalityDetermination(root, current), pos);

+ RenderObject* firstRenderObject =

leviw_travelin_and_unemployed 2014/11/20 23:34:44 Don't wrap this line.

+ firstRenderObjectForDirectionalityDetermination(root, current);

+ InlineIterator iter(root, firstRenderObject, firstRenderObject == current ? pos : 0);

InlineBidiResolver observer;

observer.setStatus(BidiStatus(root->style()->direction(),

isOverride(root->style()->unicodeBidi())));

« no previous file with comments | « LayoutTests/fast/text/bdi-get-direction-crash-expected.txt ('k') | no next file » | no next file with comments »