Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(602)

Issue 737283002: Roll WebRTC, Libjingle (Closed)

Created:
6 years, 1 month ago by tommi (sloooow) - chröme
Modified:
6 years, 1 month ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Roll Libjingle 7718:7721 TBR=kjellander@chromium.org Committed: https://crrev.com/e6771f981b26c4dae30af55a155ffbf3012c5761 Cr-Commit-Position: refs/heads/master@{#305001}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M DEPS View 1 chunk +1 line, -1 line 0 comments Download
M third_party/libjingle/README.chromium View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (2 generated)
tommi (sloooow) - chröme
6 years, 1 month ago (2014-11-20 09:24:36 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/737283002/1
6 years, 1 month ago (2014-11-20 09:25:42 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years, 1 month ago (2014-11-20 10:59:11 UTC) #5
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/e6771f981b26c4dae30af55a155ffbf3012c5761 Cr-Commit-Position: refs/heads/master@{#305001}
6 years, 1 month ago (2014-11-20 10:59:56 UTC) #6
kjellander_chromium
lgtm, but since there are WebRTC changes in that range as well, shouldn't we try ...
6 years, 1 month ago (2014-11-20 16:41:34 UTC) #7
tommi (sloooow) - chröme
6 years, 1 month ago (2014-11-21 15:29:40 UTC) #8
Message was sent while issue was closed.
On 2014/11/20 16:41:34, kjellander wrote:
> lgtm, but since there are WebRTC changes in that range as well, shouldn't we
try
> to roll both in the same CL for such cases?

Hm... strange. This was generated by the roll script, so I wonder why it didn't
pick up the webrtc changes?

Powered by Google App Engine
This is Rietveld 408576698