Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(351)

Issue 737153002: Preparation for Chrome experiment to enable bandwidth resumption. (Closed)

Created:
6 years, 1 month ago by ramant (doing other things)
Modified:
6 years, 1 month ago
Reviewers:
Ryan Hamilton
CC:
chromium-reviews, cbentzel+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@SentPacketManager_to_pass_in_HAS_RETRANSMITTABLE_DATA_80171666
Project:
chromium
Visibility:
Public.

Description

Preparation for Chrome experiment to enable bandwidth resumption. Protected behind FLAGS_quic_enable_bandwidth_resumption_experiment Once this CL is in, I intend to add a Chrome experiment to add the connection option kBWRE to a small percentage of connections to test the effect of turning on BW resumption. If a client provides a previously cached bandwidth estimate (that is recent, and from the same serving region), then set initial CWND based on this data. Behavior change only when both the flag is true, and the Chrome experiment adds the connection option to client handshakes. A followup CL (78446219) will add varz to track the distribution of resulting initial CWNDs. Merge internal change: 80239310 R=rch@chromium.org

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+195 lines, -25 lines) Patch
M net/quic/congestion_control/pacing_sender.h View 3 chunks +4 lines, -0 lines 0 comments Download
M net/quic/congestion_control/pacing_sender.cc View 1 chunk +5 lines, -0 lines 0 comments Download
M net/quic/congestion_control/send_algorithm_interface.h View 2 chunks +5 lines, -0 lines 0 comments Download
M net/quic/congestion_control/tcp_cubic_sender.h View 3 chunks +5 lines, -0 lines 0 comments Download
M net/quic/congestion_control/tcp_cubic_sender.cc View 3 chunks +28 lines, -9 lines 0 comments Download
M net/quic/congestion_control/tcp_cubic_sender_test.cc View 1 chunk +27 lines, -0 lines 0 comments Download
M net/quic/crypto/crypto_protocol.h View 1 chunk +3 lines, -0 lines 0 comments Download
M net/quic/quic_connection.h View 1 chunk +5 lines, -0 lines 0 comments Download
M net/quic/quic_connection.cc View 1 chunk +5 lines, -0 lines 0 comments Download
M net/quic/quic_crypto_server_stream.h View 2 chunks +2 lines, -2 lines 0 comments Download
M net/quic/quic_crypto_server_stream.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M net/quic/quic_flags.h View 1 chunk +2 lines, -0 lines 0 comments Download
M net/quic/quic_flags.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M net/quic/quic_sent_packet_manager.h View 2 chunks +5 lines, -0 lines 0 comments Download
M net/quic/quic_sent_packet_manager.cc View 1 chunk +5 lines, -0 lines 0 comments Download
M net/quic/quic_server_session.cc View 1 chunk +21 lines, -6 lines 0 comments Download
M net/quic/quic_time.h View 1 chunk +2 lines, -0 lines 0 comments Download
M net/quic/test_tools/quic_test_utils.h View 1 chunk +1 line, -0 lines 0 comments Download
M net/tools/quic/quic_server_session.cc View 1 chunk +21 lines, -6 lines 0 comments Download
M net/tools/quic/quic_server_session_test.cc View 1 chunk +40 lines, -0 lines 0 comments Download
M net/tools/quic/test_tools/quic_test_utils.h View 2 chunks +3 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
ramant (doing other things)
6 years, 1 month ago (2014-11-19 23:11:39 UTC) #1
Ryan Hamilton
6 years, 1 month ago (2014-11-20 01:07:07 UTC) #2
lgtm

Powered by Google App Engine
This is Rietveld 408576698