Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 737093002: Stop overloading internal_dispose in SkTextBlob and SkData (Closed)

Created:
6 years, 1 month ago by bsalomon
Modified:
6 years, 1 month ago
Reviewers:
mtklein
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Visibility:
Public.

Description

Stop overloading internal_dispose in SkTextBlob and SkData Committed: https://skia.googlesource.com/skia/+/072803144a623f1a59eb73ca5f3ddf45222b5e06

Patch Set 1 #

Total comments: 2

Patch Set 2 : Fix speeling error and assert that blobs are always placement newed. #

Patch Set 3 : fix warning #

Patch Set 4 : fix unused named param warning (grrr!) #

Patch Set 5 : ARGGGGGGHHHH #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -29 lines) Patch
M include/core/SkData.h View 1 1 chunk +8 lines, -1 line 0 comments Download
M include/core/SkTextBlob.h View 1 2 3 4 1 chunk +9 lines, -1 line 0 comments Download
M src/core/SkData.cpp View 3 chunks +1 line, -20 lines 0 comments Download
M src/core/SkTextBlob.cpp View 1 chunk +0 lines, -7 lines 0 comments Download

Messages

Total messages: 19 (8 generated)
bsalomon
6 years, 1 month ago (2014-11-19 21:45:30 UTC) #2
mtklein
lgtm https://codereview.chromium.org/737093002/diff/1/include/core/SkData.h File include/core/SkData.h (right): https://codereview.chromium.org/737093002/diff/1/include/core/SkData.h#newcode174 include/core/SkData.h:174: // can unconditionally released using sk_free in and ...
6 years, 1 month ago (2014-11-19 21:56:59 UTC) #3
bsalomon
https://codereview.chromium.org/737093002/diff/1/include/core/SkData.h File include/core/SkData.h (right): https://codereview.chromium.org/737093002/diff/1/include/core/SkData.h#newcode174 include/core/SkData.h:174: // can unconditionally released using sk_free in and overloaded ...
6 years, 1 month ago (2014-11-20 14:49:57 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/737093002/20001
6 years, 1 month ago (2014-11-20 14:55:53 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: Build-Ubuntu13.10-Clang-x86_64-Debug-Trybot on client.skia.compile (http://build.chromium.org/p/client.skia.compile/builders/Build-Ubuntu13.10-Clang-x86_64-Debug-Trybot/builds/764) Build-Ubuntu13.10-GCC4.8-Arm7-Debug-Android-Trybot on client.skia.compile (http://build.chromium.org/p/client.skia.compile/builders/Build-Ubuntu13.10-GCC4.8-Arm7-Debug-Android-Trybot/builds/759) Build-Ubuntu13.10-GCC4.8-x86_64-Release-Trybot ...
6 years, 1 month ago (2014-11-20 14:57:24 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/737093002/40001
6 years, 1 month ago (2014-11-20 15:06:54 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: Build-Ubuntu13.10-Clang-x86_64-Debug-Trybot on client.skia.compile (http://build.chromium.org/p/client.skia.compile/builders/Build-Ubuntu13.10-Clang-x86_64-Debug-Trybot/builds/766) Build-Ubuntu13.10-GCC4.8-Arm7-Debug-Android-Trybot on client.skia.compile (http://build.chromium.org/p/client.skia.compile/builders/Build-Ubuntu13.10-GCC4.8-Arm7-Debug-Android-Trybot/builds/761) Build-Ubuntu13.10-GCC4.8-x86_64-Release-Trybot ...
6 years, 1 month ago (2014-11-20 15:08:38 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/737093002/60001
6 years, 1 month ago (2014-11-20 15:14:54 UTC) #14
commit-bot: I haz the power
Try jobs failed on following builders: Build-Ubuntu13.10-GCC4.8-Arm7-Debug-Android-Trybot on client.skia.compile (http://build.chromium.org/p/client.skia.compile/builders/Build-Ubuntu13.10-GCC4.8-Arm7-Debug-Android-Trybot/builds/763)
6 years, 1 month ago (2014-11-20 15:16:30 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/737093002/80001
6 years, 1 month ago (2014-11-20 15:53:07 UTC) #18
commit-bot: I haz the power
6 years, 1 month ago (2014-11-20 16:02:52 UTC) #19
Message was sent while issue was closed. 
Committed patchset #5 (id:80001) as
https://skia.googlesource.com/skia/+/072803144a623f1a59eb73ca5f3ddf45222b5e06

Powered by Google App Engine
This is Rietveld 408576698