Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(196)

Issue 737033003: Do not restart the device if the data was not wiped. (Closed)

Created:
6 years, 1 month ago by navabi
Modified:
6 years, 1 month ago
Reviewers:
Anton, jbudorick, rmcilroy
CC:
chromium-reviews, klundberg+watch_chromium.org, yfriedman+watch_chromium.org, jbudorick+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Do not restart the device if the data was not wiped. The reboot for the devices was added because after a wipe certain settings require a reboot to take effect. When the device is not wiped, there is no reason to reboot it. We need the ability to have bots that will not reboot devices, because some devices have boot-screen prompt as a security feature. BUG= Committed: https://crrev.com/e52d00fb93f6db33a1d0488b5610cebd96fda82f Cr-Commit-Position: refs/heads/master@{#304969}

Patch Set 1 #

Patch Set 2 : Ooops. I don't want this patch. Will undo. #

Patch Set 3 : Remove last commit. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -2 lines) Patch
M build/android/provision_devices.py View 1 chunk +3 lines, -2 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
navabi
6 years, 1 month ago (2014-11-19 22:00:45 UTC) #2
navabi
PTAL. Ignore Patch Set 2. 1 and 3 are the same (I accidentally uploaded a ...
6 years, 1 month ago (2014-11-20 00:29:31 UTC) #3
jbudorick
lgtm
6 years, 1 month ago (2014-11-20 00:30:59 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/737033003/40001
6 years, 1 month ago (2014-11-20 00:33:54 UTC) #6
commit-bot: I haz the power
Committed patchset #3 (id:40001)
6 years, 1 month ago (2014-11-20 04:10:49 UTC) #7
commit-bot: I haz the power
6 years, 1 month ago (2014-11-20 04:11:39 UTC) #8
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/e52d00fb93f6db33a1d0488b5610cebd96fda82f
Cr-Commit-Position: refs/heads/master@{#304969}

Powered by Google App Engine
This is Rietveld 408576698