pkg/docgen/lib/docgen.dart - Issue 737033002: Let docgen detect a dart-sdk directory that's differently named, and do it correctly on bleeding ed…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: pkg/docgen/lib/docgen.dart

Issue 737033002: Let docgen detect a dart-sdk directory that's differently named, and do it correctly on bleeding ed… (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: A much better implementation, actually use the --sdk value Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: pkg/docgen/lib/docgen.dart

diff --git a/pkg/docgen/lib/docgen.dart b/pkg/docgen/lib/docgen.dart

index 428f4c7fae623882541b37019c1c5bb310c8a6da..a9f171a2c79c45a0d4fe8a8a153f6fc4c06857bd 100644

--- a/pkg/docgen/lib/docgen.dart

+++ b/pkg/docgen/lib/docgen.dart

@@ -44,7 +44,7 @@ Future<bool> docgen(List<String> files, {String packageRoot,

bool includeDependentPackages: false, bool compile: false,

bool serve: false, bool noDocs: false, String startPage,

String pubScript : 'pub', String dartBinary: 'dart',

- bool indentJSON: false}) {

+ bool indentJSON: false, String sdk}) {

var result;

if (!noDocs) {

viewer.ensureMovedViewerCode();

@@ -55,7 +55,7 @@ Future<bool> docgen(List<String> files, {String packageRoot,

excludeLibraries: excludeLibraries,

includeDependentPackages: includeDependentPackages,

startPage: startPage, pubScriptValue: pubScript,

- dartBinaryValue: dartBinary, indentJSON: indentJSON);

+ dartBinaryValue: dartBinary, indentJSON: indentJSON, sdk: sdk);

viewer.addBackViewerCode();

if (compile || serve) {

result.then((success) {

« no previous file with comments | « pkg/docgen/bin/docgen.dart ('k') | pkg/docgen/lib/src/generator.dart » ('j') | no next file with comments »