Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(829)

Issue 736953003: Removed unnecessary generalization of all fields in Map::GeneralizeRepresentation() (introduced in … (Closed)

Created:
6 years, 1 month ago by Igor Sheludko
Modified:
6 years, 1 month ago
Reviewers:
Toon Verwaest
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Project:
v8
Visibility:
Public.

Description

Removed unnecessary generalization of all fields in Map::GeneralizeRepresentation() (introduced in r25082). This generalization caused unnecessary map deprecation when the transition tree of the split map is full. BUG=chromium:431807 LOG=N Committed: https://chromium.googlesource.com/v8/v8/+/a2422af2fc594e7778deced16aebd131c6191747

Patch Set 1 #

Patch Set 2 : Addressed comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -9 lines) Patch
M src/objects.h View 1 1 chunk +1 line, -1 line 0 comments Download
M src/objects.cc View 1 4 chunks +17 lines, -8 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
Igor Sheludko
PTAL
6 years, 1 month ago (2014-11-19 17:10:31 UTC) #2
Toon Verwaest
lgtm
6 years, 1 month ago (2014-11-19 17:40:53 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/736953003/20001
6 years, 1 month ago (2014-11-19 17:43:09 UTC) #5
commit-bot: I haz the power
6 years, 1 month ago (2014-11-19 18:10:20 UTC) #6
Message was sent while issue was closed.
Committed patchset #2 (id:20001)

Powered by Google App Engine
This is Rietveld 408576698