Support aria-grabbed attribute.

Support aria-grabbed attribute.

This patch adds implementation for isAriaGrabbed() and introduces new
enum type for true,false and undefined for aria attributs.

The related spec is http://goo.gl/QIFcWc and http://goo.gl/tYnx6G.

BUG=98817
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=185648

[je_julie(Not used), 2014-11-19 15:08:19]

je_julie.kim@samsung.com changed reviewers:
+ dmazzoni@chromium.org

[je_julie(Not used), 2014-11-19 15:14:13]

je_julie.kim@samsung.com changed reviewers:
+ mkwst@chromium.org

[je_julie(Not used), 2014-11-19 15:18:24]

Hi Dominic and Mike,

This patch introduces new enum type for checking if aria attribute is defined
and exposes API to get aria-grabbed attribute to chromium using it.
The related patch is WIP on https://codereview.chromium.org/736023002/.

PTAL.

[Mike West, 2014-11-19 16:01:02]

mkwst@chromium.org changed required reviewers:
+ dmazzoni@chromium.org

[Mike West, 2014-11-19 16:01:02]

This LGTM. Please wait for Dominic to sign off on the implementation before
landing it, however.

[dmazzoni, 2014-11-19 17:20:17]

https://codereview.chromium.org/736943002/diff/1/Source/modules/accessibility...
File Source/modules/accessibility/AXObject.h (right):

https://codereview.chromium.org/736943002/diff/1/Source/modules/accessibility...
Source/modules/accessibility/AXObject.h:264: enum AccessibilityDefined {
The enum looks great but I'm not sure I like calling it "Defined", because
really it's a boolean true / false, that also supports being undefined.

How about:

enum AccessibilityOptionalBool {
    OptionalBoolUndefined = 0,
    OptionalBoolTrue = 1,
    OptionalBoolFalse = 2
}

[je_julie(Not used), 2014-11-20 02:37:43]

I updated patchset with new enum type.
PTAL.

https://codereview.chromium.org/736943002/diff/1/Source/modules/accessibility...
File Source/modules/accessibility/AXObject.h (right):

https://codereview.chromium.org/736943002/diff/1/Source/modules/accessibility...
Source/modules/accessibility/AXObject.h:264: enum AccessibilityDefined {
On 2014/11/19 17:20:17, dmazzoni wrote:
> The enum looks great but I'm not sure I like calling it "Defined", because
> really it's a boolean true / false, that also supports being undefined.
> 
> How about:
> 
> enum AccessibilityOptionalBool {
>     OptionalBoolUndefined = 0,
>     OptionalBoolTrue = 1,
>     OptionalBoolFalse = 2
> }
Good idea. 
I updated patchset with that.

[dmazzoni, 2014-11-20 07:02:13]

The CQ bit was checked by dmazzoni@chromium.org

[dmazzoni, 2014-11-20 07:02:13]

lgtm

[commit-bot: I haz the power, 2014-11-20 07:03:03]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/736943002/20001

[commit-bot: I haz the power, 2014-11-20 08:25:35]

Committed patchset #2 (id:20001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=185648