Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(446)

Issue 73693004: Merge 235302 "Fix crash in WebContentsViewAura::WindowObserver t..." (Closed)

Created:
7 years, 1 month ago by jam
Modified:
7 years, 1 month ago
Reviewers:
jam
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam
Visibility:
Public.

Description

Merge 235302 "Fix crash in WebContentsViewAura::WindowObserver t..." > Fix crash in WebContentsViewAura::WindowObserver that happens when switching tabs. The exact repro steps were: > > 1) open an empty page > 2) print preview > 3) open a new tab > 4) go back to original tab > 5) close print preview > 6) switch to the new tab > > The crash happened at step 4 because the second tab got removed from the same root window as the print preview's observer. We weren't unobserving all the children of the root window at that point. > > BUG=318791 > R=ben@chromium.org > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=235267 > > Review URL: https://codereview.chromium.org/69813005 TBR=jam@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=235443

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -0 lines) Patch
M chrome/browser/ui/webui/print_preview/print_preview_ui_browsertest.cc View 1 chunk +16 lines, -0 lines 0 comments Download
M content/browser/web_contents/web_contents_view_aura.cc View 1 chunk +7 lines, -0 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
jam
7 years, 1 month ago (2013-11-15 21:54:53 UTC) #1

          

Powered by Google App Engine
This is Rietveld 408576698