Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2437)

Unified Diff: Source/web/PopupMenuTest.cpp

Issue 736883002: Implement <select> Popup Menu using PagePopup (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Fixed tests for mac Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/web/PopupMenuImpl.cpp ('k') | Source/web/WebPagePopupImpl.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/web/PopupMenuTest.cpp
diff --git a/Source/web/PopupMenuTest.cpp b/Source/web/PopupMenuTest.cpp
index ee9a0c1fdc43e6cc46ee602668f19460f2a7efd1..a80c37d02d78f66b03d0edc42b80317d75dfacab 100644
--- a/Source/web/PopupMenuTest.cpp
+++ b/Source/web/PopupMenuTest.cpp
@@ -122,6 +122,9 @@ public:
virtual bool itemIsSelected(unsigned listIndex) const { return listIndex == m_selectIndex; }
virtual bool valueShouldChangeOnHotTrack() const { return false; }
virtual void setTextFromItem(unsigned listIndex) { }
+ virtual IntRect elementRectRelativeToRootView() const override { return IntRect(); }
+ virtual Element& ownerElement() const override { return *toElement(m_node); }
+ virtual RenderStyle* renderStyleForItem(Element& element) const override { return nullptr; }
virtual FontSelector* fontSelector() const { return 0; }
virtual HostWindow* hostWindow() const { return 0; }
@@ -596,6 +599,7 @@ TEST_F(SelectPopupMenuStyleTest, DISABLED_PopupListBoxRTLRowWidth)
TEST_F(SelectPopupMenuStyleTest, PopupListBoxRTLRowWidth)
#endif
{
+ RuntimeEnabledFeatures::setHTMLPopupMenuEnabled(false);
registerMockedURLLoad("select_rtl_width.html");
loadFrame(mainFrame(), "select_rtl_width.html");
HTMLSelectElement* select = toHTMLSelectElement(mainFrame()->frame()->document()->focusedElement());
« no previous file with comments | « Source/web/PopupMenuImpl.cpp ('k') | Source/web/WebPagePopupImpl.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698