Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2029)

Unified Diff: Source/web/WebViewImpl.h

Issue 736883002: Implement <select> Popup Menu using PagePopup (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/web/WebViewImpl.h
diff --git a/Source/web/WebViewImpl.h b/Source/web/WebViewImpl.h
index 8229f02da34f3fd48b87772a7d4344c4887f4b33..e1d4e11193787ddf05fc1d85b5d7c8d7e82b99f0 100644
--- a/Source/web/WebViewImpl.h
+++ b/Source/web/WebViewImpl.h
@@ -68,7 +68,6 @@ class DataObject;
class Frame;
class FullscreenController;
class LinkHighlight;
-class PopupContainer;
class RenderLayerCompositor;
class UserGestureToken;
class WebActiveGestureAnimation;
@@ -414,8 +413,6 @@ public:
const WebPoint& dragImageOffset);
// Notification that a popup was opened/closed.
- void popupOpened(PopupContainer*);
- void popupClosed(PopupContainer*);
PagePopup* openPagePopup(PagePopupClient*, const IntRect& originBoundsInRootView);
void closePagePopup(PagePopup*);
LocalDOMWindow* pagePopupWindow() const;
@@ -437,8 +434,7 @@ public:
virtual void setVisibilityState(WebPageVisibilityState, bool) override;
- PopupContainer* selectPopup() const { return m_selectPopup.get(); }
- bool hasOpenedPopup() const { return m_selectPopup || m_pagePopup; }
+ bool hasOpenedPopup() const { return m_pagePopup; }
// Returns true if the event leads to scrolling.
static bool mapKeyCodeForScroll(
@@ -566,8 +562,6 @@ private:
// Returns true if the view was scrolled.
bool scrollViewWithKeyboard(int keyCode, int modifiers);
- void hideSelectPopup();
-
// Converts |pos| from window coordinates to contents coordinates and gets
// the HitTestResult for it.
HitTestResult hitTestResultForWindowPos(const IntPoint&);
@@ -697,9 +691,6 @@ private:
// current drop target in this WebView (the drop target can accept the drop).
WebDragOperation m_dragOperation;
- // The popup associated with a select element.
- RefPtrWillBePersistent<PopupContainer> m_selectPopup;
-
// The popup associated with an input element.
RefPtr<WebPagePopupImpl> m_pagePopup;

Powered by Google App Engine
This is Rietveld 408576698